Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3608 MEDIA.BUFFER_READ_OUT_OF_BOUNDS error when CEA caption packets are empty #3609

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Fix #3608 MEDIA.BUFFER_READ_OUT_OF_BOUNDS error when CEA caption packets are empty #3609

merged 1 commit into from
Sep 9, 2021

Conversation

caridley
Copy link
Contributor

Description

Fixes #3608
Added check for empty caption packets in closed_caption_parser.
Added a unit test that verifies the closed_caption_parser now works with a video segment that contains empty caption packets.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have signed the Google CLA https://cla.developers.google.com
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have verified my change on multiple browsers on different platforms
  • I have run ./build/all.py and the build passes
  • I have run ./build/test.py and all tests pass

@caridley
Fix shaka-project#3608 MEDIA.BUFFER_READ_OUT_OF_BOUNDS error when CEA…
ea46fba 
… caption packets are empty

Added check for empty caption packets in closed_caption_parser.

Added a unit test that verifies the closed_caption_parser now works with a video segment that contains empty caption packets.
@avelad
Copy link
Member

avelad commented Sep 9, 2021

@joeyparrish can you review it? I'm very interested on it.

@joeyparrish
Copy link
Member

Approved, waiting for bot to run tests

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 97ba4df into shaka-project:master Sep 9, 2021
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
@caridley @joeyparrish
fix(cea): Fix BUFFER_READ_OUT_OF_BOUNDS error when CEA caption packet…
734682d 
…s are empty (#3609)

Added check for empty caption packets in closed_caption_parser.

Added a unit test that verifies the closed_caption_parser now works with a video segment that contains empty caption packets.

Fixes #3608
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
@caridley @joeyparrish
fix(cea): Fix BUFFER_READ_OUT_OF_BOUNDS error when CEA caption packet…
3da6589 
…s are empty (#3609)

Added check for empty caption packets in closed_caption_parser.

Added a unit test that verifies the closed_caption_parser now works with a video segment that contains empty caption packets.

Fixes #3608
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MEDIA.BUFFER_READ_OUT_OF_BOUNDS error when CEA caption packets are empty
4 participants
@caridley @avelad @joeyparrish @shaka-bot