Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always build the same input files to a stable output #300

Merged
merged 1 commit into from
Mar 4, 2016

Conversation

johan
Copy link
Contributor

@johan johan commented Mar 4, 2016

#299, but for the preview branch. As I haven't tested this and don't generally speak a lot of python, vet with extra caution.

(Leaning just on traversal order, two different checkouts may produce different
file list orders for different people building, on some OS:es / file systems.)
@shaka-bot
Copy link
Collaborator

Testing in progress...

@shaka-bot
Copy link
Collaborator

Failure:

+ ./build/all.py
101 files checked, no errors found.
+ git checkout github/master -- karma.conf.js
+ export NODE_PATH=/usr/local/lib/node_modules
+ NODE_PATH=/usr/local/lib/node_modules
+ xvfb-run karma start --single-run --no-colors --reporters junit,dots --log-level disable --browsers Chrome
Chrome 49.0.2623 (Linux 0.0.0): Executed 0 of 0 ERROR (0.003 secs / 0 secs)

@joeyparrish
Copy link
Member

Let me investigate. Our build bot is still fairly new, so this might be the bot's fault.

@johan
Copy link
Contributor Author

johan commented Mar 4, 2016

Seems it builds happily at my end (and the exact same output, save the git hash) both before and after the change, so that sounds likely. This change may not even be necessary for the python version, if its filesystem traversing api:s already are defined to return files in sorted order.

@shaka-bot
Copy link
Collaborator

Testing in progress...

@joeyparrish
Copy link
Member

There was a bug in the bot's job script. We made a mistake in the v1-v2 transition. Should be working for both branches now.

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish self-assigned this Mar 4, 2016
@joeyparrish joeyparrish added the type: enhancement New feature or request label Mar 4, 2016
@joeyparrish
Copy link
Member

@johan Thanks so much!

joeyparrish added a commit that referenced this pull request Mar 4, 2016
Always build the same input files to a stable output
@joeyparrish joeyparrish merged commit 6ea5789 into shaka-project:preview Mar 4, 2016
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants