-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always build the same input files to a stable output #300
Conversation
(Leaning just on traversal order, two different checkouts may produce different file list orders for different people building, on some OS:es / file systems.)
Testing in progress... |
Failure:
|
Let me investigate. Our build bot is still fairly new, so this might be the bot's fault. |
Seems it builds happily at my end (and the exact same output, save the git hash) both before and after the change, so that sounds likely. This change may not even be necessary for the python version, if its filesystem traversing api:s already are defined to return files in sorted order. |
Testing in progress... |
There was a bug in the bot's job script. We made a mistake in the v1-v2 transition. Should be working for both branches now. |
All tests passed! |
@johan Thanks so much! |
Always build the same input files to a stable output
#299, but for the
preview
branch. As I haven't tested this and don't generally speak a lot of python, vet with extra caution.