Check for define.amd along with typeof(define) #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent crashing with other module loaders that support `define`, but are not full AMD module loaders, check for `define.amd` as well before defining the AMD module.
|
Hi Jesper, Thanks for the contribution! I would be happy to accept this pull request, but I will need you to first read CONTRIBUTING.md and follow the instructions there. In brief, you need to sign a click-through agreement with Google and add yourself to AUTHORS & CONTRIBUTORS. Thanks again! |
|
Sorry about that, it totally slipped my mind! It should all be done now! |
joeyparrish
added a commit
that referenced
this pull request
Aug 26, 2015
Check for define.amd along with typeof(define)
|
Thanks! |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent crashing with other module loaders that support
define, but are not full AMD module loaders, check fordefine.amdas well before defining the AMD module.