Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor HttpFetchPlugin to clarify error outcomes #1532

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Refactor HttpFetchPlugin to clarify error outcomes #1532

merged 1 commit into from
Aug 14, 2018

Commits on Aug 8, 2018

  1. Refactor HttpFetchPlugin to clarify error outcomes 

    Previously, HttpFetchPlugin would treat any non-Shaka error as
HTTP_ERROR when there were potentially other circumstances which
could have produced a non-Shaka error.

This change catches errors from fetch sooner, so that there is no
need to do a fuzzy check for error.severity. It also clears the
request timeout regardless of whether fetch throws or not.

Closes shaka-project#1519
    Fillmore, Christopher (cf276p) committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    301c0e3 View commit details
    Browse the repository at this point in the history