Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new request type TIMING for clock sync requests #1489

Merged

Conversation

pcruiksh
Copy link
Contributor

@pcruiksh pcruiksh commented Jul 11, 2018

Adds shaka.net.NetworkingEngine.RequestType.TIMING for identification of clock sync requests in networking filters. Fixes #1488.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@pcruiksh pcruiksh force-pushed the bugfix/addRequestTypeForClockSync branch from 2170459 to 671d307 Compare July 11, 2018 16:45
@googlebot
Copy link

CLAs look good, thanks!

@joeyparrish
Copy link
Member

Looks good, but can you please update CONTRIBUTORS and AUTHORS as well? There are notes at the top about how to do that, but please make sure to keep them alphabetized. Thanks!

Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@joeyparrish
Copy link
Member

I'm just going to have the build bot check it out. It's not doing anything magical, so it if it reports any failures, just run build/all.py and build/test.py locally to reproduce. If all the tests pass, I'll merge it.

@shaka-bot
Copy link
Collaborator

Test Failure:

Chrome 67.0.3396 (Linux 0.0.0)
  DashParser Live stop interrupts UTCTiming requests FAILED
    Expected spy request to have been called with [ 0, <jasmine.objectContaining(Object({ uris: [ 'http://foo.bar/date' ] }))> ] but actual calls were [ 4, Object({ uris: [ 'http://foo.bar/date' ], method: 'GET', body: null, headers: Object({  }), allowCrossSiteCredentials: false, retryParameters: Object({ maxAttempts: 2, baseDelay: 1000, backoffFactor: 2, fuzzFactor: 0.5, timeout: 0 }) }) ].
        at Function.shaka.test.FakeNetworkingEngine.expectRequest (test/test/util/fake_networking_engine.js:91:22)
        at shaka.test.FakeNetworkingEngine.expectRequest (test/test/util/fake_networking_engine.js:215:35)
        at test/dash/dash_parser_live_unit.js:894:23
        at eval (node_modules/promise-polyfill/lib/index.js:61:13)

Failed 1 tests, passed 1352, skipped 51

@joeyparrish
Copy link
Member

Looks like one test needs updating. You can check results locally with build/all.py (to lint and compile everything) and build/test.py (to run the tests). Thanks!

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish
Copy link
Member

Thanks for your contribution!

@joeyparrish joeyparrish merged commit e312c3a into shaka-project:master Jul 16, 2018
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants