Fix playback of VDMS assets in demo app #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should no longer set "include credentials" on license requests. Doing so results in a CORS error. This change fixes playback of a couple assets in the demo player.
joeyparrish
approved these changes
Apr 2, 2018
|
All tests passed! |
joeyparrish
pushed a commit
that referenced
this pull request
Apr 2, 2018
We should no longer set "include credentials" on VDMS license requests. Doing so results in a CORS error. This change fixes playback of a couple assets in the demo player.
|
Thanks! Cherry-picked for v2.3.6. |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 04-02-2018 VDMS manifest servers are no longer passing
data via cookies. As such the servers are no longer setting
'Access-Control-Allow-Credentials' header in the response.
The demo player is currently configured to set include credentials
for the VDMS assets and without the Allow Credentials error we get
a CORS error when attempting playback:
The value of the 'Access-Control-Allow-Credentials' header in the response is '' which must be 'true' when the request's credentials mode is 'include'. Origin 'https://shaka-player-demo.appspot.com' is therefore not allowed access
This change updates the VDMS asset callback to ensure that the credential
mode is no longer 'include'.