-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't wait for sessions to close on DrmEngine#destroy #1168
Don't wait for sessions to close on DrmEngine#destroy #1168
Conversation
This is a workaround for Chrome bug https://crbug.com/690583. Resolves shaka-project#1093
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. No reason we have to wait for the session to be closed, if we asked for it to be closed and we are reasonably confident that the browser will close it at some point. It's not an exclusive resource like the video element or MediaSource, so we should be able to move on and still open new sessions later.
All tests passed! |
Thanks for the PR! The build bot likes it, I like it, so I'm merging it now. |
This is a workaround for Chrome bug https://crbug.com/690583 Resolves #1093
This is causing failures in offline storage scenarios. I'm going to try to fix it, but I may have to revert your PR. The problem is that when Even when you wait for |
I found a way to fix it. Instead of trusting close() or ignoring it, we can trust it for 1 second, then ignore it if it doesn't resolve in that time. This seems to work in my tests. |
Thanks! |
An improved workaround for https://crbug.com/690583 and #1093, on top of PR #1168. If we don't wait at all, we end up trying to use the same session ID too quickly, which causes a playback failure. Change-Id: I8c9d1a0f09432054b862e033b80b0c2f47739c74
Should be fixed now. |
An improved workaround for https://crbug.com/690583 and #1093, on top of PR #1168. If we don't wait at all, we end up trying to use the same session ID too quickly, which causes a playback failure. Change-Id: I8c9d1a0f09432054b862e033b80b0c2f47739c74
This is a workaround for Chrome bug https://crbug.com/690583.
Resolves #1093