-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop fetching live stream while paused #982
Comments
Approving, when player is paused on live conent, it still downloads video segmetns to update images. It is bug, i suppose, user downloads segments when it is not necessary. |
Confirm the bug. |
@joeyparrish, please answer us |
Hi all, The "needs triage" label means we are aware of the issue but have not reproduced it or scheduled any changes. We will get to this as soon as we can. We apologize for the delay. |
It seems that there are two things at work here.
For now, I propose that we suppress forced seeks based on the seek range while paused. (This is in Tentatively scheduled for v2.3. |
"But perhaps we should consider an exception where if paused and outside the seek range, we stop buffering." - what if there will be long DVR, for exampe 24 hours? It will still download for 24 hours. I propose to dome some configurable parameter, that configures x seconds timeout after which not to download new segments after x seconds of being paused. |
No, it wouldn't download for 24 hours in that scenario. If the buffering goal were set to 60 seconds, it would only download 60 seconds of content ahead of the playhead. If we are paused, the playhead wouldn't move (change 1 above) and we'd stop buffering soon. So in essence, the parameter you propose already exists: |
O, thats fine |
Just wanted to mention that this issue is on our radar. We have a requirement to allow users to pause live video for long periods of time. |
Thanks, Chris. Many other things are slipping to v2.4, but this is still scheduled for v2.3. |
Regarding v2.3 , when you plan release it , is it scheduled for 2017 ? |
Yes, we plan to release v2.3 in 2017. I would like to give a more specific timeline, but it is difficult to predict when we will finish work on the critical issues that make up that milestone. You can track progress by watching the number of open and closed issues in the milestone. |
@joeyparrish really need this fix. We have the same requirement as @chrisfillmore. Until you guys push 2.3, are there any suggestions on something we can do with the current APIs to mock the effect of it not buffering, so users don't see frames changing constantly? Thanks :) |
I'm sorry, there's nothing I can think of. Forced seeks in PlayheadObserver should be suppressed while the video is paused. If you need a fix sooner than we can provide one, you always have the option of submitting a pull request. Sorry for the delay. |
Fixing: when a livestream is paused, we force the playhead back in if the playhead falls out of the seek range, which makes the paused image change. Now we'll jump when the user hits play. Closes #982. Change-Id: I3f9e05e15c710488477b70ea7642f007c771ea92
The fix has been cherry-picked to v2.2.4. |
@joeyparrish That's fantastic! Thanks. |
Happy to help! Kudos to @michellezhuogg for doing the actual work. :-) |
We got 2.2.4 version and timeShiftBufferDepth="PT299.50S" |
@kuznetcoff777 Could you open a separate issue for the problem you found with repo steps? It will be easier for us to track as a bug separate from the original enhancement. |
What version of Shaka Player are you using: latest of demo app
Can you reproduce the issue with our latest release version: yes
Can you reproduce the issue with the latest code from
master
: yesAre you using the demo app or your own custom app: demo app
What browser and OS are you using: chrome 60 on macOS Sierra 10.12
What are the manifest and license server URIs: Big Buck Bunny (live) from demo app
What did you do?
load -> pause
What did you expect to happen?
The video.currentTime should remain at the paused position. the video should present the same image until play.
What actually happened?
each downloaded chunk updates the currentTime and the video image.
Note the scrubber, once is reaching to the start it's happening.
The text was updated successfully, but these errors were encountered: