Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No key status on 2017 Tizen TVs #891

Closed
joeyparrish opened this issue Jun 16, 2017 · 7 comments
Closed

No key status on 2017 Tizen TVs #891

joeyparrish opened this issue Jun 16, 2017 · 7 comments
Labels
platform: TV/STB Issues affecting smart TV or set-top box platforms status: archived Archived and locked; will not be updated type: external An issue with an external dependency; not our issue; sometimes kept open for tracking

Comments

@joeyparrish
Copy link
Member

There seems to be no key status information on 2017 Tizen TVs. This causes a timeout in one of our DRM integration tests, but more concerning is that we may not be able to make the right decisions for some content without this information.

We need to:

  1. File a bug against Samsung
  2. Work around the test failure
  3. Work around any content issues that arise from this

This is related to #884 for 2016 TVs, in which the EME polyfill sends out a fake key status event, but without any valid key IDs in it. We must solve #884 in order to work without key status information. The difference with 2017 TVs is that there is no polyfill and no key status event at all.
@joeyparrish joeyparrish added type: bug Something isn't working correctly type: external An issue with an external dependency; not our issue; sometimes kept open for tracking labels Jun 16, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone Jun 16, 2017
shaka-bot pushed a commit that referenced this issue Jun 16, 2017
@joeyparrish
Work around Tizen DRM test failure
849891a 
Instead of hanging while we wait for key status events that will never
come, move on after 5 seconds.

Issue #891

Change-Id: Ia338401097fb29039fa203729d0efaa4cca5623b
@chrisfillmore
Copy link
Contributor

Fyi I have both a 2016 and 2017 TV now if I can assist with troubleshooting.

@joeyparrish joeyparrish mentioned this issue Jun 19, 2017
Closed
This was referenced Jun 19, 2017
Closed
Closed
shaka-bot pushed a commit that referenced this issue Jun 22, 2017
@joeyparrish
Work around lack of Tizen key statuses in tests
07d067b 
If we haven't gotten a key status within 5 seconds of updating a
session, consider the session "loaded".  This fixes a hung Promise
in DrmEngine for offline use-cases.

Issue #891
Issue #894

Change-Id: Ic4c7478198a0db4b3a3df8842d5f8cd1f6f3e8bd
@joeyparrish
Copy link
Member Author

Work-arounds are in place now, but we still have not been able to file bugs against Samsung/Tizen. Having trouble getting an account on their JIRA instance.

@joeyparrish joeyparrish modified the milestone: v2.2.0 Jun 22, 2017
@chrisfillmore
Copy link
Contributor

Yes I tried that too and also couldn't get an account. I'll talk to Samsung and get in touch with you.

joeyparrish added a commit that referenced this issue Jul 17, 2017
@joeyparrish
Work around Tizen DRM test failure
b01ef25 
Instead of hanging while we wait for key status events that will never
come, move on after 5 seconds.

Issue #891

Change-Id: Ia338401097fb29039fa203729d0efaa4cca5623b
joeyparrish added a commit that referenced this issue Jul 17, 2017
@joeyparrish
Work around lack of Tizen key statuses in tests
f59cbb3 
If we haven't gotten a key status within 5 seconds of updating a
session, consider the session "loaded".  This fixes a hung Promise
in DrmEngine for offline use-cases.

Issue #891
Issue #894

Change-Id: Ic4c7478198a0db4b3a3df8842d5f8cd1f6f3e8bd
@joeyparrish
Copy link
Member Author

Work-arounds have been cherry-picked and will be released in v2.1.5.

@joeyparrish joeyparrish removed type: bug Something isn't working correctly type: enhancement New feature or request labels Aug 24, 2017
@joeyparrish joeyparrish removed their assignment Nov 22, 2017
@joeyparrish joeyparrish added the platform: TV/STB Issues affecting smart TV or set-top box platforms label Jul 17, 2018
@EloB
Copy link

EloB commented Oct 19, 2018

Did you managed to run any drm on Tizen 2017/2016 and have a stable playback?

@chrisfillmore
Copy link
Contributor

@EloB in general protected playback with Shaka works on Tizen 2017 TV's and newer. The implementation of EME on 2016 model TV's is extremely buggy, and I would caution you against trying to support that platform.

@joeyparrish
Copy link
Member Author

Samsung will never fix this, so there's no need for us to continue tracking it. I'm closing it now.

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
platform: TV/STB Issues affecting smart TV or set-top box platforms status: archived Archived and locked; will not be updated type: external An issue with an external dependency; not our issue; sometimes kept open for tracking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@EloB @TheModMaker @joeyparrish @chrisfillmore