Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEA-708 - commands P16 #7926

Closed
mtoczko opened this issue Jan 22, 2025 · 1 comment · Fixed by #7929
Closed

CEA-708 - commands P16 #7926

mtoczko opened this issue Jan 22, 2025 · 1 comment · Fixed by #7929
Assignees
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@mtoczko
Copy link

mtoczko commented Jan 22, 2025

Have you read the FAQ and checked for duplicate open issues?
Yes, #7829 #7837

If the problem is related to FairPlay, have you read the tutorial?

No

What version of Shaka Player are you using?

v4.12.8

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from main?
yes

Are you using the demo app or your own custom app?
demo

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
MacOS 15.2, Chrome 131.0.6778.266

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

https://mtoczko.github.io/hls-test-streams/test-cea708-p16/playlist.m3u8
https://mtoczko.github.io/hls-test-streams/test-cea708-p16/captions.txt

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

What did you do?

What did you expect to happen?
Correctly decode captions 708 from a sample stream containing characters outside of G0.
Stream contains alphabets from the languages POL, CZE, SVK, RUS, UKR, BLR, BGR, SRB, MKD, GRC, HUN, EST, LVA, LTU, TUR, IRL, FIN, ALB

  Show all details
Poland
A Ą B C Ć D E Ę F G H I J K L Ł M N Ń O Ó
P R S Ś T U W Y Z Ź Ż

a ą b c ć d e ę f g h i j k l ł m n ń o ó
p r s ś t u w y z ź ż

Czech Republic
A Á B C Č D Ď E É Ě F G H I Í J K L M N Ň
O Ó P Q R Ř S Š T Ť U Ú Ů V W X Y Ý Z Ž

a á b c č d ď e é ě f g h i í j k l m n ň
o ó p q r ř s š t ť u ú ů v w x y ý z ž

Slovakia
A Á Ä B C Č D Ď E É F G H CH I Í J K L Ľ Ĺ
M N Ň O Ó Ô P Q R Ŕ S Š T Ť U Ú V W X Y Ý
Z Ž

a á ä b c č d ď e é f g h ch i í j k l ľ ĺ
m n ň o ó ô p q r ŕ s š t ť u ú v w x y ý
z ž

Russian
А Б В Г Д Е Ё Ж З И Й К Л М Н О П Р С Т У
Ф Х Ц Ч Ш Щ Ъ Ы Ь Э Ю Я

а б в г д е ё ж з и й к л м н о п р с т у
ф х ц ч ш щ ъ ы ь э ю я

Ukrainian
А Б В Г Ґ Д Е Є Ж З И І Ї Й К Л М Н О П Р
С Т У Ф Х Ц Ч Ш Щ Ь Ю Я

а б в г ґ д е є ж з и і ї й к л м н о п р
с т у ф х ц ч ш щ ь ю я

Belarusian
А Б В Г Д Е Ё Ж З І Й К Л М Н О П Р С Т У
Ў Ф Х Ц Ч Ш Ы Ь Э Ю Я

а б в г д е ё ж з і й к л м н о п р с т у
ў ф х ц ч ш ы ь э ю я

Bulgarian
А Б В Г Д Е Ж З И Й К Л М Н О П Р С Т У Ф
Х Ц Ч Ш Щ Ъ Ь Ю Я

а б в г д е ж з и й к л м н о п р с т у ф
х ц ч ш щ ъ ь ю я

Serbian
А Б В Г Д Ђ Е Ж З И Ј К Л Љ М Н Њ О П Р С
Т Ћ У Ф Х Ц Ч Џ Ш

а б в г д ђ е ж з и ј к л љ м н њ о п р с
т ћ у ф х ц ч џ ш

Macedonian
А Б В Г Д Ѓ Е Ж З Ѕ И Ј К Л Љ М Н Њ О П Р
С Т Ќ У Ф Х Ц Ч Џ Ш

а б в г д ѓ е ж з ѕ и ј к л љ м н њ о п р
с т ќ у ф х ц ч џ ш

Greek
Α Β Γ Δ Ε Ζ Η Θ Ι Κ Λ Μ Ν Ξ Ο Π Ρ Σ Τ Υ Φ
Χ Ψ Ω

α β γ δ ε ζ η θ ι κ λ μ ν ξ ο π ρ σ τ υ φ
χ ψ ω

Hungarian
A Á B C Cs D Dz Dzs E É F G Gy H I Í J K L
Ly M N Ny O Ó Ö Ő P Q R S Sz T Ty U Ú Ü Ű
V W X Y Z Zs

a á b c cs d dz dzs e é f g gy h i í j k l
ly m n ny o ó ö ő p q r s sz t ty u ú ü ű
v w x y z zs

Estonian
A B D E F G H I J K L M N O Õ P R S Š Z Ž
T U V Ä Ö Ü

a b d e f g h i j k l m n o õ p r s š z ž
t u v ä ö ü

Latvian
A Ā B C Č D E Ē F G Ģ H I Ī J K Ķ L Ļ M N
Ņ O P R S Š T U Ū V Z Ž

a ā b c č d e ē f g ģ h i ī j k ķ l ļ m n
ņ o p r s š t u ū v z ž

Lithuanian
A Ą B C Č D E Ę Ė F G H I Į J K L M N O P
R S Š T U Ų Ū V Z Ž

a ą b c č d e ę ė f g h i į j k l m n o p
r s š t u ų ū v z ž

Turkish
A B C Ç D E F G Ğ H I İ J K L M N O Ö P R
S Ş T U Ü V Y Z

a b c ç d e f g ğ h i i̇ j k l m n o ö p r
s ş t u ü v y z

Irish
A Á B C D E É F G H I Í L M N O Ó P R S T
U Ú

a á b c d e é f g h i í l m n o ó p r s t
u ú

Finnish
A B C D E F G H I J K L M N O P Q R S T U
V W X Y Z Å Ä Ö

a b c d e f g h i j k l m n o p q r s t u
v w x y z å ä ö

Saami
A Á B C Č D Đ E F G H I J K L M N Ŋ O P R
S Š T Ŧ U V Z Ž

a á b c č d đ e f g h i j k l m n ŋ o p r
s š t ŧ u v z ž

Albanian
A B C Ç D DH E Ë F G Gj H I J K L LL M N
Nj O P Q R RR S Sh T Th U V X Xh Y Z Zh

a b c ç d dh e ë f g gj h i j k l ll m n
nj o p q r rr s sh t th u v x xh y z zh

What actually happened?

Function prevents proper decoding of unicode
0x18 0x01 0x7c => Unicode 17c => ż

const isTextBlock = (b) => {
return (b >= 0x20 && b <= 0x7f) || (b >= 0xa0 && b <= 0xff);
};

Are you planning to send a PR to fix it?
No

@mtoczko mtoczko added the type: bug Something isn't working correctly label Jan 22, 2025
@avelad avelad added component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels Jan 22, 2025
@avelad avelad added this to the v4.13 milestone Jan 22, 2025
@mtoczko mtoczko changed the title CEA-708 - comand P16 CEA-708 - commands P16 Jan 22, 2025
@avelad
Copy link
Member

avelad commented Jan 22, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants