feat: Add Watermark Support to Shaka Player UI #7877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chafroudtarek
changed the title
tykus160
added
type: enhancement
tykus160
requested changes
Jan 13, 2025
avelad
reviewed
Jan 13, 2025
avelad
reviewed
Jan 13, 2025
avelad
requested changes
Jan 13, 2025
|
Incremental code coverage: 33.09% |
avelad
reviewed
Jan 13, 2025
avelad
requested changes
Jan 13, 2025
avelad
requested changes
Jan 13, 2025
avelad
reviewed
Jan 13, 2025
…nd remove unused watermark.less file
…nd remove unused less/watermark.less file
avelad
approved these changes
Jan 13, 2025
tykus160
reviewed
Jan 13, 2025
|
Please add the following Shaka demo code. Thanks! |
avelad
reviewed
Jan 13, 2025
tykus160
approved these changes
Jan 14, 2025
|
Should I fix this error in Build and Test / macos-latest Edge ? @tykus160 |
tykus160
requested changes
Jan 14, 2025
tykus160
reviewed
Jan 14, 2025
tykus160
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces watermark support for the Shaka Player UI.
Added functionality to overlay static or dynamic watermarks on videos.
Included options to customize position, size, color, and opacity.
Enhanced content security with dynamic watermarking capabilities.
Resolves #7726 .