Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Watermark Support for Shaka Player UI #7726

Closed
chafroudtarek opened this issue Dec 9, 2024 · 5 comments · Fixed by #7877
Closed

Add Watermark Support for Shaka Player UI #7726

chafroudtarek opened this issue Dec 9, 2024 · 5 comments · Fixed by #7877
Assignees
Labels
component: UI The issue involves the Shaka Player UI type: enhancement New feature or request
Milestone

Comments

@chafroudtarek
Copy link
Contributor

This feature introduces a watermark functionality to Shaka Player's UI. It allows developers to add static or dynamic watermarks to video playback.

Key Features:

  1. Static Watermark:
  • Display a fixed watermark on the video player.

  • Options for position (e.g., top-right, bottom-left), color, size, and opacity.

  1. Dynamic Watermark:
  • Adds a moving watermark that changes position periodically.

  • Supports customization for text, transition duration, display duration, and alpha blending.

  1. Customizable Options:
  • Developers can specify text, size, color, and animation intervals.
  1. Removal and Cleanup:
  • The watermark can be programmatically removed or reset.

  • This feature enhances content security by discouraging unauthorized distribution and ensures compliance with branding or licensing requirements.

@chafroudtarek chafroudtarek added the type: enhancement New feature or request label Dec 9, 2024
@chafroudtarek chafroudtarek changed the title Feature: Add Watermark Support for Shaka Player UI feat(watermark): Add Watermark Support for Shaka Player UI Dec 9, 2024
@shaka-bot shaka-bot added this to the Backlog milestone Dec 9, 2024
@avelad
Copy link
Member

avelad commented Dec 9, 2024

@chafroudtarek Are you interested in creating a PR to add this feature?

@avelad avelad added the component: UI The issue involves the Shaka Player UI label Dec 9, 2024
@joeyparrish joeyparrish changed the title feat(watermark): Add Watermark Support for Shaka Player UI Add Watermark Support for Shaka Player UI Dec 10, 2024
@avelad
Copy link
Member

avelad commented Jan 2, 2025

I'm going to leave the issue open for 7 days to see if anyone is interested in implementing this. The Shaka maintainers team is not interested in integrating this into the Shaka UI, sorry!

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 2, 2025
@shaka-bot
Copy link
Collaborator

Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including @shaka-bot reopen in a comment.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 9, 2025
@chafroudtarek
Copy link
Contributor Author

hey @avelad I hope you're doing well. I noticed that this issue has been closed due to inactivity. I apologize for the lack of updates on my end, as I was busy over the last few days.

The good news is that the feature is now implemented and I am ready to push the changes for your review. Could you please reopen the issue so I can share the updates?

Thank you for your understanding and support

@avelad avelad reopened this Jan 10, 2025
@avelad
Copy link
Member

avelad commented Jan 10, 2025

@chafroudtarek reopened!

tykus160 pushed a commit that referenced this issue Jan 14, 2025
This pull request introduces watermark support for the Shaka Player UI.

Added functionality to overlay static or dynamic watermarks on videos.
Included options to customize position, size, color, and opacity.
Enhanced content security with dynamic watermarking capabilities.
Resolves #7726 .
@avelad avelad modified the milestones: Backlog, v4.13 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants