Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add 'downloadcompleted' event #7608

Closed
vlazh opened this issue Nov 15, 2024 · 2 comments · Fixed by #7609 or #7597
Closed

feat: Add 'downloadcompleted' event #7608

vlazh opened this issue Nov 15, 2024 · 2 comments · Fixed by #7609 or #7597
Assignees
@vlazh
Labels
component: networking The issue involves the networking system of Shaka Player priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v4.13

Comments

@vlazh
Copy link
Contributor

vlazh commented Nov 15, 2024

Is your feature request related to a problem? Please describe.

NetworkEngine can notify about download failed but there is no way to know when the download is completed (before filters applied). It needs for custom Abr managers, at least, to correct track start and end body downloads.

Describe the solution you'd like

I suggest to add event 'downloadcompleted' and modify NetworkEngine for that.

Are you planning send a PR to add it?
Yes.
@vlazh vlazh added the type: enhancement New feature or request label Nov 15, 2024
@avelad avelad added priority: P3 Useful but not urgent component: networking The issue involves the networking system of Shaka Player labels Nov 15, 2024
@tykus160
Copy link
Member

@vlazh if you're interested, I have a working solution for this already but couldn't find time before to pushing it back.

@vlazh vlazh mentioned this issue Nov 15, 2024
Merged
@shaka-bot shaka-bot added this to the Backlog milestone Nov 15, 2024
@vlazh
Copy link
Contributor Author

vlazh commented Nov 15, 2024

@tykus160 Yes, I'm interested, thanx.

tykus160 pushed a commit that referenced this issue Nov 18, 2024
@vlazh
feat: Add 'downloadcompleted' event (#7609)
13186bd 
Closes #7608
@shaka-bot shaka-bot mentioned this issue Nov 18, 2024
Merged
@avelad avelad modified the milestones: Backlog, v4.13 Jan 13, 2025
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 17, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vlazh vlazh

Labels
component: networking The issue involves the networking system of Shaka Player priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.13
4 participants
@vlazh @avelad @shaka-bot @tykus160