-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLS manifest version 7 is not playing in Shaka Player #1730
Comments
Looks like we are treating uri attribute of the media tag as required, which is wrong unless the tag describes subtitles.
Thanks for the report, we will work on it. |
@ismena - I have a fix for this, which branch label should I use in my pull request? Thanks, Rob |
@rgc feel free to use master. |
The commit message in adde0bd is malformed, but this issue was fixed by that commit. |
Fix cherry-picked for v2.4.6. |
Have you read the FAQ and checked for duplicate open issues?: yes
What version of Shaka Player are you using?: latest
Can you reproduce the issue with our latest release version?: yes
Can you reproduce the issue with the latest code from
master
?: yesAre you using the demo app or your own custom app?: demo
If custom app, can you reproduce the issue using our demo app?: yes
What browser and OS are you using?: Chrome
What are the manifest and license server URIs?:
https://timesmmdod-mmd-cust.lldns.net/v1/gaana/mp4/26/1836026/21206608/stream.ismd/master.m3u8?stream=21206608_128;21206608_16
What did you do?
I played this manifest under custom asset
What did you expect to happen?
Mp3 file should render and play the song
What actually happened?
Getting the below error:
main.js:695 Player error shaka.util.Error {severity: 2, category: 4, code: 4023, data: Array(1), handled: false, …}category: 4code: 4023data: ["URI"]handled: falsemessage: "Shaka Error MANIFEST.HLS_REQUIRED_ATTRIBUTE_MISSING (URI)"severity: 2stack: "Error: Shaka Error MANIFEST.HLS_REQUIRED_ATTRIBUTE_MISSING (URI)↵ at new shaka.util.Error (https://shaka-player-demo.appspot.com/lib/util/error.js:89:13)↵ at Function.shaka.hls.HlsParser.getRequiredAttributeValue_ (https://shaka-player-demo.appspot.com/lib/hls/hls_parser.js:1781:11)↵ at shaka.hls.HlsParser.createStreamInfoFromMediaTag_ (https://shaka-player-demo.appspot.com/lib/hls/hls_parser.js:808:23)↵ at shaka.hls.HlsParser. (https://shaka-player-demo.appspot.com/lib/hls/hls_parser.js:545:17)↵ at Array.map ()↵ at shaka.hls.HlsParser.createVariantsForTag_ (https://shaka-player-demo.appspot.com/lib/hls/hls_parser.js:544:28)↵ at shaka.hls.HlsParser. (https://shaka-player-demo.appspot.com/lib/hls/hls_parser.js:452:19)↵ at Array.map ()↵ at shaka.hls.HlsParser. (https://shaka-player-demo.appspot.com/lib/hls/hls_parser.js:451:40)"__proto__: Object
shakaDemo.onError_ @ main.js:695
(anonymous) @ asset_section.js:370
Promise.then (async)
shakaDemo.load @ asset_section.js:339
Error Code : 4023
The text was updated successfully, but these errors were encountered: