Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent sessions not removed #171

Closed
joeyparrish opened this issue Aug 29, 2015 · 0 comments
Closed

Persistent sessions not removed #171

joeyparrish opened this issue Aug 29, 2015 · 0 comments
Assignees
@TheModMaker
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v1.6.0

Comments

@joeyparrish
Copy link
Member

When deleting encrypted content that was previously stored for offline playback, persisted sessions should be loaded into the CDM and remove() should be called to release those licenses back to the server. This was accidentally omitted from our implementation of offline playback.

This should be handled by shaka.player.OfflineVideoSource.prototype.deleteGroup and shaka.media.EmeManager.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Aug 29, 2015
@joeyparrish joeyparrish modified the milestone: v1.6.0 Sep 1, 2015
@TheModMaker TheModMaker self-assigned this Sep 21, 2015
TheModMaker added a commit that referenced this issue Oct 7, 2015
@TheModMaker @joeyparrish
Deleting offline content now deletes persistent session.
7d43821 
Closes #171

Change-Id: Ia0ff2c9892f53c2ceeddb2b589e2e2c886aea54a
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
3 participants
@TheModMaker @joeyparrish @shaka-bot