-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server certificate is not configured before Store and Delete operations #1623
Comments
Call configureCertificate before Store and Delete calls, when certificateUri is given. Fixes shaka-project#1623.
@gigon When I try your content, it plays without issue. Now I noticed that in the content your provided the cert path was different from the cert you sent us. After fixing that, everything played without issue on master. |
@vaage The issue is not about playback, it is about download. This optimization is demonstrated in case of playback, but in case of Download (and also in the release of a persistent license!), the demo application does not preload the certificate I set in the Custom field. You can see this by looking at XHR requests in the chrome debugger. I added code to the demo application, to preload the certificate, in a Pull request I submitted. Please correct me if I misunderstand. |
Call setServerCertificate before store and delete operations, when serverCertificate exists. In demo application, request and configure certificate when certificateUri is given in asset. Fixes shaka-project#1623.
Call setServerCertificate before store and delete operations, when serverCertificate exists. In demo application, request and configure certificate when certificateUri is given in asset. Fixes #1623
Released in v2.5.0-beta2. |
Have you read the FAQ and checked for duplicate open issues?: Yes
What version of Shaka Player are you using?: v2.5.0-beta-master
Can you reproduce the issue with our latest release version?: yes
Can you reproduce the issue with the latest code from
master
?: yesAre you using the demo app or your own custom app?: demo app
If custom app, can you reproduce the issue using our demo app?: yes
What browser and OS are you using?: Chrome/Windows 10
What are the manifest and license server URIs?:
Will send the manifest, license, and certificate URIs to shaka-player-issues@google.com
What did you do?
Added my asset to the demo assets list OR filled the manifest, license, and certificate URIs as Custom asset, select my asset and download it.
What did you expect to happen?
a) No errors in the debug console
b) The first (and only) license request raised from the CDM is for a license.
What actually happened?
a) The call to storage.configure raises an error: "Invalid config, unrecognized key .progressCallback"
b) The first license request raised from the CDM is for a widevine certificate (2nd one is for a license)
The text was updated successfully, but these errors were encountered: