Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDATA in DASH Location tag #1508

Closed
tmagnien opened this issue Jul 27, 2018 · 4 comments
Closed

CDATA in DASH Location tag #1508

tmagnien opened this issue Jul 27, 2018 · 4 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@tmagnien
Copy link

Hi. We're using DASH Location tag to load-balance our streams on different servers.

However, our URL has a query string and & characters should be quoted to &. I tried enclosing it in a CDATA block but it does not seem to work. Is this normal ? (Using & works but it would be easier for me not to rewrite the URL).

Thanks,
Thierry

@vaage vaage added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jul 27, 2018
@TheModMaker
Copy link
Contributor

You need to double escape it. & For example:

<Location>http://example.com/?q=foo&amp;amp;bar</Location>

Once we parse this, it will be sent to the server as http://example.com/?q=foo&amp;bar.

@vaage vaage removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jul 27, 2018
@vaage
Copy link
Contributor

vaage commented Jul 27, 2018

@tmagnien does @TheModMaker instructions fix your problem?

@vaage vaage added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jul 27, 2018
@tmagnien
Copy link
Author

Hi. Sorry, I realize my question was not clear.

To sum up, this works:
<Location>http://somedomain/url?foo=1&amp;bar=2</Location>

But this is ignored:
<Location><![CDATA[http://somedomain/url?foo=1&bar=2]]></Location>

And I wanted to know if this is expected behaviour, as the 2nd form using CDATA is easier for me to generate.

Thanks,
Thierry

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jul 28, 2018
@TheModMaker
Copy link
Contributor

I don't really see a reason this shouldn't be supported. It should be a simple fix. I'll add it to our next release.

@TheModMaker TheModMaker added type: bug Something isn't working correctly and removed needs triage labels Jul 30, 2018
@TheModMaker TheModMaker added this to the v2.5 milestone Jul 30, 2018
@TheModMaker TheModMaker self-assigned this Jul 30, 2018
joeyparrish pushed a commit that referenced this issue Aug 6, 2018
Fixes #1508

Change-Id: I04817c8077b298b56ea11cb8cb8d1a6e832ce4ee
@shaka-project shaka-project locked and limited conversation to collaborators Sep 28, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants