Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip text AdaptationSets with no segment info #1484

Closed
joeyparrish opened this issue Jul 2, 2018 · 0 comments
Closed

Skip text AdaptationSets with no segment info #1484

joeyparrish opened this issue Jul 2, 2018 · 0 comments
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.5

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?: yes

What version of Shaka Player are you using?: v2.4.2

Can you reproduce the issue with our latest release version?: yes

Can you reproduce the issue with the latest code from master?: yes

Are you using the demo app or your own custom app?: demo

What browser and OS are you using?: Chrome Linux

What are the manifest and license server URIs?:
The manifest referenced in shaka-project/shaka-packager#422

What did you do?
Play the manifest referenced above.

What did you expect to happen?
No parser failure

What actually happened?
DASH parser failure

The manifest contains a text AdaptationSet with SegmentTemplate, no duration, and no SegmentTimeline. Since text failures tend to be soft ones, there's no good reason we shouldn't skip that AdaptationSet and play the video & audio.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jul 2, 2018
@joeyparrish joeyparrish added this to the v2.5 milestone Jul 2, 2018
@joeyparrish joeyparrish self-assigned this Jul 2, 2018
@joeyparrish joeyparrish mentioned this issue Jul 2, 2018
Closed
@jakubvojacek jakubvojacek mentioned this issue Jul 12, 2018
Closed
5 tasks
joeyparrish added a commit that referenced this issue Aug 6, 2018
@joeyparrish
Skip text AdaptationSets with no segment info
d0cdfcd 
See also shaka-project/shaka-packager#422

Closes #1484

Change-Id: I293468a39918a4a8487d15ec70b365eec3dd1ebc
@shaka-project shaka-project locked and limited conversation to collaborators Sep 1, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.5
Development

No branches or pull requests
2 participants
@joeyparrish @shaka-bot