-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog dates #1263
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Comments
@nocarryr Thanks for finding that. We appreciate the attention to detail. |
👍 @vaage Thanks for helping to make shaka-player such a great product! |
Thanks! I have updated the corresponding text on the github releases page: https://github.com/google/shaka-player/releases/tag/v2.2.10 https://github.com/google/shaka-player/releases/tag/v2.3.1 |
Cherry-picked to v2.3.2 |
joeyparrish
pushed a commit
that referenced
this issue
Feb 1, 2018
Fix Wrong Year in CHANGELOG It looks like 2017 was such a great year for Shaka Player that we did not want it to end, so in our CHANGELOG we decided to start 2017 all over again. This change updated the two entries to say 2018 instead of 2017. Backported to v2.3.x Closes #1263
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
The two most recent additions to CHANGELOG.md seem to have the wrong year:
2.3.1 and 2.2.10
Seems a bit "nit-picky", but could be a point of confusion.
The text was updated successfully, but these errors were encountered: