Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari 11 MediaSource failures #1048

Closed
joeyparrish opened this issue Oct 3, 2017 · 4 comments
Closed

Safari 11 MediaSource failures #1048

joeyparrish opened this issue Oct 3, 2017 · 4 comments
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.3.0

Comments

@joeyparrish
Copy link
Member

Safari 11 fails several MediaSourceEngine tests. We need to:

  1. look into the test failures
  2. file additional bugs against Apple (if necessary)
  3. improve the Safari MediaSource polyfills (if possible)
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Oct 3, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Oct 3, 2017
@joeyparrish
Copy link
Member Author 

Safari 11.0.0 (Mac OS X 10.11.6) MediaSourceEngine removes segments FAILED
	Expected 15 to be close to 10.
	test/media/media_source_engine_integration.js:142:57
	promiseReactionJob@[native code]
	Expected 15 to be close to 20.
	test/media/media_source_engine_integration.js:143:58
	promiseReactionJob@[native code]
	Expected 25 to be 20.
	test/media/media_source_engine_integration.js:146:50
	promiseReactionJob@[native code]
	Expected 5 to be close to 10.
	test/media/media_source_engine_integration.js:147:58
	promiseReactionJob@[native code]
Safari 11.0.0 (Mac OS X 10.11.6) MediaSourceEngine trims content at appendWindowEnd FAILED
	Expected 6.916666666666667 to be close to 10.
	test/media/media_source_engine_integration.js:332:57
	promiseReactionJob@[native code]
	Expected 6.916666666666667 to be close to 18, 1.
	test/media/media_source_engine_integration.js:335:57
	promiseReactionJob@[native code]
Safari 11.0.0 (Mac OS X 10.11.6): Executed 51 of 1287 (2 FAILED) (skipped 1236) (2.357 secs / 1.862 secs)

@joeyparrish
Copy link
Member Author

The failure of the "trims content at appendWindowEnd" test is caused by a bug we've been working around in Safari 10: https://bugs.webkit.org/show_bug.cgi?id=165342

We can apply the same polyfill to Safari 11.

@joeyparrish joeyparrish self-assigned this Oct 3, 2017
shaka-bot pushed a commit that referenced this issue Oct 3, 2017
@joeyparrish
Apply MSE patches to Safari 11
87b7234 
One of the Safari 10 bugs we work around is still present in Safari 11.

Issue #1048

Change-Id: I54e146bcce9770f980a0dabd477a86b482a6c901
@chrisfillmore chrisfillmore mentioned this issue Oct 4, 2017
Closed
@joeyparrish
Copy link
Member Author

New MediaSource bug filed against Safari 11: https://bugs.webkit.org/show_bug.cgi?id=177884

@joeyparrish
Copy link
Member Author

Cherry-picked to v2.2.3.

joeyparrish added a commit that referenced this issue Oct 16, 2017
@joeyparrish
Apply MSE patches to Safari 11
7146931 
One of the Safari 10 bugs we work around is still present in Safari 11.

Issue #1048

Change-Id: I54e146bcce9770f980a0dabd477a86b482a6c901
joeyparrish pushed a commit that referenced this issue Oct 16, 2017
@theodab @joeyparrish
Polyfill Safari 11 MSE bug in SourceBuffer.remove
a119d40 
SourceBuffer.remove, when told to remove exactly up to a keyframe,
will also remove that keyframe and all of the content till the next
keyframe. This results in far too much content being deleted, and is
breaking our tests on Safari 11.

Patching this by offseting the end of the removal range by 1ms seems
to be a viable workaround.

Closes #1048

Change-Id: I062b2dc2617f1372f885f4ccbc906d77c65412d7
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.3.0
Development

No branches or pull requests
2 participants
@joeyparrish @shaka-bot