PR review

restore empty lines initialy removed by eslint --fix remove logExtPrefix_
shaka-project · Nov 13, 2024 · aec671a · aec671a
1 parent 24654e0
commit aec671a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 14 deletions.
diff --git a/externs/shaka/manifest_parser.js b/externs/shaka/manifest_parser.js
@@ -140,9 +140,9 @@ shaka.extern.ManifestParser = class {
  *   getBandwidthEstimate: function():number,
  *   onMetadata: function(string, number, ?number,
  *                        !Array.<shaka.extern.MetadataFrame>),
-*    closeSegmentIndex: function(shaka.extern.Stream, function()),
-*    disableStream: function(!shaka.extern.Stream),
-*    addFont: function(string, string)
+ *   closeSegmentIndex: function(shaka.extern.Stream, function()),
+ *   disableStream: function(!shaka.extern.Stream),
+ *   addFont: function(string, string)
  * }}
  *
  * @description

diff --git a/lib/media/segment_index.js b/lib/media/segment_index.js
@@ -308,6 +308,7 @@ shaka.media.SegmentIndex = class {
     this.numEvicted_ += diff;
   }
 
+
   /**
    * Drops references that start after windowEnd, or end before windowStart,
    * and contracts the last reference so that it ends at windowEnd.

diff --git a/lib/media/streaming_engine.js b/lib/media/streaming_engine.js
@@ -35,6 +35,7 @@ goog.require('shaka.util.Mp4BoxParsers');
 goog.require('shaka.util.Mp4Parser');
 goog.require('shaka.util.Networking');
 
+
 /**
  * @summary Creates a Streaming Engine.
  * The StreamingEngine is responsible for setting up the Manifest's Streams
@@ -268,6 +269,7 @@ shaka.media.StreamingEngine = class {
     }
   }
 
+
   /**
    * Applies a playback range. This will only affect non-live content.
    *
@@ -556,6 +558,7 @@ shaka.media.StreamingEngine = class {
     }
   }
 
+
   /**
    * Switches to the given Stream. |stream| may be from any Variant.
    *
@@ -2986,17 +2989,6 @@ shaka.media.StreamingEngine = class {
   static logPrefix_(mediaState) {
     return '(' + mediaState.type + ':' + mediaState.stream.id + ')';
   }
-
-  /**
-   * @param {shaka.util.ManifestParserUtils.ContentType} type
-   * @param {number} id
-   * @return {string} A log prefix of the form [$CONTENT_TYPE:$STREAM_ID], e.g.,
-   *   "[audio:5]" or "[video:10]".
-   * @private
-   */
-  static logExtPrefix_(type, id) {
-    return '[' + type + ':' + id.toString() + ']';
-  }
 };
 
 

diff --git a/lib/util/periods.js b/lib/util/periods.js
@@ -72,6 +72,7 @@ shaka.util.PeriodCombiner = class {
         stream.segmentIndex.release();
       }
     }
+
     this.audioStreams_ = [];
     this.videoStreams_ = [];
     this.textStreams_ = [];
-Original file line number
+Diff line change
@@ Expand Up / @@ -308,6 +308,7 @@ shaka.media.SegmentIndex = class { @@
         this.numEvicted_ += diff;
       }
       /**
        * Drops references that start after windowEnd, or end before windowStart,
        * and contracts the last reference so that it ends at windowEnd.
@@ Expand Down @@