Skip to content

Commit

Permalink
ci: Fix screenshot upload (#7876)
Browse files Browse the repository at this point in the history
This is meant to fix errors like "Failed request: (409) Conflict: an
artifact with this name already exists on the workflow run" which occur
when more than one instance of a browser fails tests in the same run.

The change in behavior that led to the error likely began after updating
actions/upload-artifact.
  • Loading branch information
joeyparrish authored Jan 10, 2025
1 parent 42d8b46 commit 2fa0414
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ jobs:
uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: screenshots-${{ matrix.browser }}
name: screenshots-${{ matrix.browser }}-${{ matrix.os }}
path: |
test/test/assets/screenshots/*/*.png-new
test/test/assets/screenshots/*/*.png-diff
Expand Down

0 comments on commit 2fa0414

Please sign in to comment.