Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project dependencies so it could be cloned and built locally #33

Closed
wants to merge 2 commits into from
Closed

Fix project dependencies so it could be cloned and built locally #33

wants to merge 2 commits into from

Conversation

LelouchHe
Copy link

The current dependencies seem broken. Once cloned to local, it fails to yarn install due to dependencies build errors.

Below are the errors from yarn install

➤ YN0009: │ msgpackr-extract@npm:1.0.15 couldn't be built successfully (exit code 1, logs can be found here: C:\Users\longh\AppData\Local\Temp\xfs-41b8c800\build.log)
➤ YN0009: │ lmdb-store@npm:1.6.13 couldn't be built successfully (exit code 1, logs can be found here: C:\Users\longh\AppData\Local\Temp\xfs-7d83501c\build.log)

The major error from build log is:

\logseq-inbox-telegram-plugin\node_modules\nan\nan_callbacks.h(55,23): error C2039: 'AccessorSignature': is not a member of 'v8' [\logseq-inbox-telegram-plugin\node_modules\lmdb-store\build\lmdb.vcxproj]

Based on nan_callbacks.h:55:23: error: ‘AccessorSignature’ is not a member of ‘v8’ #942, packages are updated to fix this error.

It also add .yarnrc.yml and .yarn/ to .gitignore

longh added 2 commits February 11, 2023 20:16
The current dependencies seem broken. Once cloned to local, it fails to `yarn install` due to dependencies errors.

This is to update the dependencies to make it work locally
@shady2k
Copy link
Owner

shady2k commented Feb 12, 2023

It's strange, but I have no errors. How can I reproduce this problem?

  • Clone the repository
  • Execute yarn install
    Is it right?

@LelouchHe
Copy link
Author

LelouchHe commented Feb 12, 2023

It's strange, but I have no errors. How can I reproduce this problem?

  • Clone the repository
  • Execute yarn install
    Is it right?

Yes. My dev environment is new, since I just installed the node (v19.6.0) and other tools before I cloned this repository.

@shady2k
Copy link
Owner

shady2k commented Feb 12, 2023

It forces me to install Buffer.

@parcel/resolver-default: Auto installing polyfill for Node builtin module "buffer"...

/Users/shady/Documents/repos/logseq-inbox-telegram-plugin/node_modules/axios/lib/helpers/toFormData.js:128:74
127 | if (utils.isArrayBuffer(value) || utils.isTypedArray(value)) {

128 | return useBlob && typeof Blob === 'function' ? new Blob([value]) : Buffer.from(value);
| ^^^^^^ used here
129 | }
130 |

📝 Learn more: https://parceljs.org/features/node-emulation/#polyfilling-%26-excluding-builtin-node-modules

Installing buffer...

"devDependencies": {
"buffer": "^5.5.0",
"parcel": "^2.8.3"
},

@LelouchHe
Copy link
Author

LelouchHe commented Feb 12, 2023

it does the same thing for mine when i continued to update the code. do you know whether we should update that and others? maybe yours still uses the build cache from previous build? i'm new to node, so i'm not quite sure.

btw, what is your node version? should i try the 18.14? or does it matter here?

@LelouchHe LelouchHe closed this by deleting the head repository Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants