-
-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: updated github issue templates #1972
Conversation
The link for the forum is useless , I will check the rest in an hour :) |
This information should also be included in Quickstart.md This is where regular users come in, who are getting to know GitHub for the first time and don't know all the details. I think it's time to add all the information regarding the issues (that they should be technical or aimed at improvement), regarding modules, system requirements, problems of other forks, and so on. I mean, it's time to make an emulator welcome window. Perhaps this step will help to avoid the same type of problems that have to be distracted. |
I also think we should make an emulator welcome window. This could serve as a barrier of entry for people who pirate things as we could tell the user to put the system modules in sys_modules and scan for them (similar to what PCSX2 does) before continuing. But most importantly this information should be upfront on the README.md for this repo. Or maybe on https://shadps4.net as the first thing you see there are blog posts. |
For "Application bug report" -> I thing the log is not needed For config.yml, replace it by:
We are working on the wiki, we plan to have an initial release today |
Addressed the review comments.
|
Seem's good for me |
Is there an option to attach a screenshot or video everywhere? Also, I think it's worth adding an item about modules, sys and sce. https://github.com/shadps4-emu/shadps4-game-compatibility?tab=readme-ov-file#informations |
Any screenshot can be attached to description or reproduction steps. |
I think I've addressed all comments, please confirm. |
It may also be worth adding here that there may be a "Pull requests" that is already aimed at eliminating this problem. |
I think it's too much to ask from a user. Most PRs are very technical in their description and do not state all the games they are fixing. Also I think it is fine to have an issue that will be closed by a WIP PR. |
Maybe you're right. At the moment, I don't see any problems, it seems that all the necessary information is present. But if anything, it will always be possible to correct or supplement it in the future. Good job. |
Let's go ! |
Don't forget reuse ci check :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing. For logs we should ask for the log type to be set as 'sync' to avoid cut-off logs.
Can be an idea to put sync by default ? |
In my personal opinion, I don't think this is necessary. It will be possible to make some changes to the interface if the task is to collect data, but this is no longer relevant for this PR. |
These issue templates were
stolenborrowed as best practices from PCSX2 and modified according to our needs.