build: Update MoltenVK and fix missing add_dependencies for copy. #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added in an update to MoltenVK while I'm at it, includes a fix for an incorrect texture atomics error on M1 family GPUs. |
squidbus
changed the title
Younes-Bel
pushed a commit
to Younes-Bel/shadPS4
that referenced
this pull request
Dec 29, 2024
…adps4-emu#1970) * build: Fix missing add_dependencies for MoltenVK copy target. * externals: Update MoltenVK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this before and caught it in a CI run in my fork today without cache. Apparently this target dependency needs to be added for it to know how to make the dylib file, adding the file dependency to the copy command isn't enough alone.