Qt: fix deprecation warnings #1672
Conversation
|
Modern Qt without this PR: EOL Qt with this PR:
https://doc.qt.io/qt-6/qcheckbox.html#signals Noble, which the current build system depends on, uses Qt 6.4. 6.4 has been EOL since 2023-03-31. Switching the CI to Ubuntu 24.10 (Oracular) won't help, as while it does ship newer Qt, it's still an old EOL version without support at 6.6 25.04 (which should release 2025-05-xx) should work fine, but that's 5 months away, though I don't really see an alternative unless you want to somehow ifdef it for different Qt versions (is that even doable?). TL;DR this either has to:
EDIT: Conflicts after 3f1061d |
|
I updated it. |
|
Is it still up to date? |
|
Looks like it, but it also still misses any Qt version check ifdefs, as per my previous message, so can't be pulled as is. |
oltolm
force-pushed
the
qt6
branch
2 times, most recently
from
d493df0 to
6c7d197
Compare
|
I added ifdefs. |
src/qt_gui/check_update.cpp
Outdated
| @@ -254,7 +253,11 @@ void CheckUpdate::setupUI(const QString& downloadUrl, const QString& latestDate, | |||
| connect(noButton, &QPushButton::clicked, this, [this]() { close(); }); | |||
|
|
|||
| autoUpdateCheckBox->setChecked(Config::autoUpdate()); | |||
| #if (QT_VERSION < QT_VERSION_CHECK(6, 8, 0)) | |||
There was a problem hiding this comment.
Shouldn't these two checks be <6.7.0?
https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/6.7.0/release-note.md
5a96d13bb5 QCheckBox: add new checkStateChanged(Qt::CheckState) signal
Added new checkStateChanged(Qt::CheckState) signal, obsoleting stateChanged(int).
src/qt_gui/settings_dialog.cpp
Outdated
| @@ -130,8 +130,13 @@ SettingsDialog::SettingsDialog(std::span<const QString> physical_devices, | |||
| // GENERAL TAB | |||
| { | |||
| #ifdef ENABLE_UPDATER | |||
| #if (QT_VERSION < QT_VERSION_CHECK(6, 8, 0)) | |||
No description provided.