-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing in an optional plugin_arg #297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oops misclicked request review. Ignore that. 🤣 |
Shouldn't it be an array of strings? @Mygod
Otherwise, we can only pass one argument to plugins. It should be more flexible. I could modify it for you if you will. |
It's for internal use only and we only need one but sure feel free to change it. |
It works perfectly. I am going to merge it now. |
A quick question, I got this kind of errors when building the master branch. Anything I missed here?
|
Upgrade your Rust :P rust-lang/rust#72239 |
😅 |
To be used by shadowsocks/shadowsocks-android#2585.
@madeye Please review?