Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIB_ONLY issue when building libshadowsocks-libev.a by CMake #2443

Closed
ghost opened this issue Jul 30, 2019 · 2 comments
Closed

LIB_ONLY issue when building libshadowsocks-libev.a by CMake #2443

ghost opened this issue Jul 30, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 30, 2019

It seems that building libshadowsocks-libev.a by CMake with no LIB_ONLY defined. It makes no _start_ss_local_server when some EXE linking with libshadowsocks-libev.a. Locally I resolved it by updating src/CMakeLists.txt:184 to:

target_compile_definitions(shadowsocks-libev PUBLIC -DMODULE_LOCAL -DLIB_ONLY)
@madeye
Copy link

madeye commented Jul 30, 2019

Please open a pull request.

@ghost
Copy link
Author

ghost commented Jul 30, 2019

@madeye Sorry, I can't. My environment is a mess now.

@madeye madeye closed this as completed in e3c6c80 Jul 30, 2019
JamisHoo added a commit to JamisHoo/shadowsocks-libev that referenced this issue Apr 13, 2020
@JamisHoo
Also apply LIB_ONLY for shared library, fix shadowsocks#2443
bbb2849
madeye added a commit that referenced this issue Apr 29, 2020
@madeye
Merge pull request #2685 from JamisHoo/master
236c98d 
Also apply LIB_ONLY for dynamic library, fix #2443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@madeye