Fix loophole in hoisting where an OpVar's uses might not be properly registered for replacement
#6212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egistered for replacement
csyonghe
approved these changes
Jan 29, 2025
|
|
||
| // This is a bit of a hack.. ideally we need to add the var to the worklist for | ||
| // further processing rather than replicating those operations here. | ||
| // |
There was a problem hiding this comment.
Why can’t we just do as the comment said?
There was a problem hiding this comment.
I believe the body of the loop needs a small rewrite. I can do this in a follow-up PR.
There was a problem hiding this comment.
Opened an issue to track this cleanup: #6214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.