Fix combined sampler documentation and warning #6207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheneym2
force-pushed
the
cheneym2/samplerbindingdoc
branch
from
91f5b68 to
07279aa
Compare
cheneym2
force-pushed
the
cheneym2/samplerbindingdoc
branch
from
a289315 to
02676d5
Compare
csyonghe
reviewed
Jan 29, 2025
| //DIAGNOSTIC_TEST:SIMPLE:-target glsl -profile ps_4_0 -entry main -no-codegen | ||
|
|
||
| // This tests that combined texture sampler objects which have D3D style register assignments, but no vk::binding, show an appropriate | ||
| // warning, even in the presence of -fvk-xxx-shift options. Warning should not recommend using -fvk-xxx-shift. |
There was a problem hiding this comment.
the comment here may need to be updated.
There was a problem hiding this comment.
Done, though I'm not sure if my update meets your expectations. What I said in this version of the comment is what I believe to be correct. Hoping it's just a matter of unclear wording.
There was a problem hiding this comment.
Ah, never mind, the comment is correct. I misunderstood it.
…ad of generic '-fvk-xxx-shift'
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
csyonghe
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates documentation around support for combined texture/samplers
for SPIR-V. The existing text implied that it was correct to use two register assignments
for explicit binding in the SPIR-V docs, but there is actually no way for Slang to derive
one vkbinding from two registers. The warning was misleading.
Related, there is a set of -fvk-xxx-shift options in slangc that do offer a way to specify
mappings from registers to vk bindings, however, they only work for 1:1 situations, not
the 2:1 mapping that comes up with combined texture samplers.
The warning which comes up when a user specifies "register" but not "vkbinding" nor
-vk-xxx-shift, is now updated to add "-vk-xxx-shift" as a suggestion for fixing the problem,
but only for the case of non-combined texture samplers.
Closes Issue #5938