Implement WaveMultiPrefix* for SPIRV and GLSL #6182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairywreath
commented
Jan 25, 2025
| //DISABLE_TEST:COMPARE_COMPUTE_EX:-slang -compute -shaderobj | ||
|
|
||
| //TEST:COMPARE_COMPUTE_EX:-slang -compute -dx12 -use-dxil -profile sm_6_5 -shaderobj | ||
| // We cannot test via GLSL as our glslang does not emit the required SPIRV version. |
There was a problem hiding this comment.
Is there a way to bump the produced SPIRV version when compiling through glsl for a test?
There was a problem hiding this comment.
You can use the __spirv_version(1.5) modifier to achieve that.
csyonghe
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6180.
Adds support for arithmetic
WaveMultiPrefix*operations for SPIRV and GLSL using SPV_NV_shader_subgroup_partitioned and GL_NV_shader_subgroup_partitioned.WaveMultiPrefix*operations for SPIRV and GLSL. Matrix variants ofWaveMultiPrefixSumandWaveMultiPrefixProductare implemented with a loop.WaveMultiPrefixBit*are not implemented as SPIRV and GLSL does not support integer matrices.WaveMultiPrefixCountBitsis not implemented as an equivalent intrinsic does not exist on SPIRV/GLSL.