Fix getArgumentValueFloat when arg is int. (#5888)

* Fix `getArgumentValueFloat` when arg is int. * format code --------- Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
shader-slang · Dec 17, 2024 · d61bba8 · d61bba8
1 parent 9c9e1f7
commit d61bba8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/source/slang/slang-reflection-api.cpp b/source/slang/slang-reflection-api.cpp
@@ -1,6 +1,7 @@
 // slang-reflection-api.cpp
 
 #include "../core/slang-basic.h"
+#include "slang-check-impl.h"
 #include "slang-check.h"
 #include "slang-compiler.h"
 #include "slang-syntax.h"
@@ -353,6 +354,15 @@ SLANG_API SlangResult spReflectionUserAttribute_GetArgumentValueFloat(
         *rs = (float)cexpr->value;
         return 0;
     }
+    else if (auto implicitCastExpr = as<ImplicitCastExpr>(userAttr->args[index]))
+    {
+        auto base = implicitCastExpr->arguments[0];
+        if (auto intLit = as<IntegerLiteralExpr>(base))
+        {
+            *rs = (float)intLit->value;
+            return 0;
+        }
+    }
     return SLANG_E_INVALID_ARG;
 }
 SLANG_API const char* spReflectionUserAttribute_GetArgumentValueString(

diff --git a/tools/slang-unit-test/unit-test-attribute-reflection.cpp b/tools/slang-unit-test/unit-test-attribute-reflection.cpp
@@ -26,12 +26,13 @@ SLANG_UNIT_TEST(attributeReflection)
         public struct NormalTextureAttribute
         {
             public E Type;
+            public float x;
         };
 
         [COM("042BE50B-CB01-4DBB-8367-3A9CDCBE2F49")]
         interface IInterface { void f(); }
 
-        [NormalTexture(E.V1)]
+        [NormalTexture(E.V1, 6)]
         struct TS {};
         )";
     String userSource = userSourceBody;
@@ -76,4 +77,8 @@ SLANG_UNIT_TEST(attributeReflection)
     int value = 0;
     normalTextureAttribute->getArgumentValueInt(0, &value);
     SLANG_CHECK(value == 1);
+
+    float fvalue = 0;
+    normalTextureAttribute->getArgumentValueFloat(1, &fvalue);
+    SLANG_CHECK(fvalue == 6.0);
 }