Only validate onblur of the field, and only if it's been edited #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The process of editing the field (the 'input' event) will activate the field for validation, and then the blur event does the actual validation. This means that clicking into (or tabbing into) a field won't do anything if you then leave that field UNLESS if you actually enter some content into the field; once some input has occurred, then the field is active, and from then onwards the blur events will trigger validation. Not the most efficient code (especially for radio/checkbox) due to the double-events, but it works. Could be made better by removing the 'input' event handler upon first use. Tested on Firefox/Linux and Chrome/Linux, with entering fields, inputting fields, chrome autofill, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process of editing the field (the 'input' event) will activate the field for validation, and then the blur event does the actual validation.
This means that clicking into (or tabbing into) a field won't do anything if you then leave that field UNLESS if you actually enter
some content into the field; once some input has occurred, then the field is active, and from then onwards the blur events will trigger validation.
Not the most efficient code (especially for radio/checkbox) due to the double-events, but it works. Could be made better by removing the 'input' event handler upon first use and/or only adding the real event handler at activation point.
Testing: