Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl + Backspace or Delete fails in preference settings input box #5

Closed
lingsamuel opened this issue Apr 24, 2020 · 3 comments · Fixed by #6
Closed

Ctrl + Backspace or Delete fails in preference settings input box #5

lingsamuel opened this issue Apr 24, 2020 · 3 comments · Fixed by #6
Assignees
Labels

Comments

@lingsamuel
Copy link

Ctrl + Backspace and Ctrl + Delete produce similar error: japaneseWordHandler.deleteWordStartLeft and japaneseWordHandler.deleteWordEndRight.

In File/Preferences/Settings input box:
image

@lingsamuel
Copy link
Author

lingsamuel commented Apr 24, 2020

Ext host log:

[2020-04-24 17:59:39.735] [exthost] [error] TypeError: Cannot read property 'document' of undefined
    at /home/lingsamuel/.vscode/extensions/sgryjp.japanese-word-handler-1.2.0/out/extension.js:11:52
...

The code:

let editor = vscode.window.activeTextEditor;
// ...
.getConfiguration("editor", editor.document.uri)
// ...

Seems that this GUI (or a rendered page?) doesn't have variable vscode.window.activeTextEditor.

@lingsamuel
Copy link
Author

Found solution in fork CJK-word-handler, commit here

"when": "textInputFocus && !editorReadonly"

To:

"when": "editorTextFocus && !editorReadonly"

@sgryjp
Copy link
Owner

sgryjp commented Apr 27, 2020

Thank you for reporting!
I reproduced the issue, and also confirmed the solution you mentioned. I'll make some time to fix this so please wait some days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants