Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check PostgreSQL major version and add linking flags if needed #28

Closed
wants to merge 1 commit into from

Conversation

golddranks
Copy link
Contributor

Fixing #27

It might be that checking the version number is an overengineered solution. The extra linking flags aren't going to make the build fail on earlier versions, they are just not needed. What do you think? (I don't have any empirical evidence about whether linking unneeded stuff bloats the binary or not.)

@clux
Copy link

clux commented May 23, 2022

I know this is super old and ignored, but any chance this can be merged in? This is the last piece that is needed to fix static builds provided users have libpgport and libpgcommon available.

@weiznich
Copy link
Collaborator

@clux If someone can provide an authoritative link to say the postgres documentation that this is the correct way to link libpq statically + goes through the comments in the linked issue we might be able to merge this. Otherwise this is unfortunately nothing that's high on my priority list, which means I personally won't spend much time working on it.

@golddranks
Copy link
Contributor Author

The authoritative view, according to the mailing list, seems to be that you shouldn't ever link libpq statically.

@weiznich
Copy link
Collaborator

That's unfortunate, as this generally sounds like this would be a really brittle solution then. #27 (comment) seems to have some information about potential duplicated symbols when linking both libraries. That might be important to add that as well here.
And to just to double check that: The mailing list threads linked in the original issue are the most "official" thing we have on this, right?

@spruce
Copy link
Contributor

spruce commented May 31, 2022

@weiznich
Copy link
Collaborator

weiznich commented Dec 7, 2023

Closed in favor of #46

@weiznich weiznich closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants