-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [Formater] Replace black with ruff #335
Conversation
@Qubitium Why I tested but it does not compress the lines. |
|
@Qubitium Yeah, I like it removing unused things. But I used My ruff version is |
@hnyls2002 We have the same ruff version so not sure our results are so different. I will investigate and check back. Did you run |
Oh, I just found out why... I did not run |
@hnyls2002 ruff has isort builtin. I will test, if result same or similar, we can remove isort and directly use ruff. EDIT: astral-sh/ruff#633 Based on the isort support, it has limitations. We need to stick with isort for now. |
It seems that your usage is not formatting but linting the repos, no wonder why it is likely to compress multiple imports into one line, this is actually done by I tested |
@hnyls2002 Confirmed. isort is dong the import merges and russ is only fixing the safe lints errors. I will work on this more. |
Reason for PR:
The PR diff shows the improvements while staying both PEP compliant and retain/improve legibility.