-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[devcontainer] add non-root user #2989
base: main
Are you sure you want to change the base?
Conversation
@@ -225,5 +225,30 @@ setopt HIST_FIND_NO_DUPS | |||
setopt INC_APPEND_HISTORY | |||
EOF | |||
|
|||
# Set workspace directory | |||
# Create non-root user with specified UID and GID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you consider using this method? https://github.com/sgl-project/sglang/blob/main/docs/developer/development_guide_using_docker.md#setup-docker-container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker pull lmsysorg/sglang:dev
docker run -itd --shm-size 32g --gpus all -v /opt/dlami/nvme/.cache:/root/.cache --ipc=host --name sglang_zhyncs lmsysorg/sglang:dev /bin/zsh
docker exec -it sglang_zhyncs /bin/zsh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After that, you can use VSCode to attach to the container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The issue happens with dev container extension. I will use this as a temp solution but we don't have to merge the code. I think your solution should work since we directly develop in a container and do not mount between local and container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ByronHsu How about using lmsysorg/sglang:dev
as a base and adding a Dockerfile.local
for VSCode development? That seems good to me.
Motivation
To fix microsoft/vscode-remote-release#49 (comment)
Modifications
Checklist