Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Fix metrics, weight update lock, request logging #2543

Merged
merged 1 commit into from
Dec 22, 2024
Merged

[Misc] Fix metrics, weight update lock, request logging #2543

merged 1 commit into from
Dec 22, 2024

Conversation

merrymercy
Copy link
Contributor

@merrymercy merrymercy commented Dec 22, 2024 •
edited
Loading

  • Update the docs and test cases of metrics
  • Fix the lock of weight update by using aiolock
  • Improve the request logging by truncating too-long fileds

@merrymercy merrymercy merged commit bbac2bf into main Dec 22, 2024
16 of 17 checks passed
@merrymercy merrymercy deleted the pr-fix branch December 22, 2024 14:25
merrymercy added a commit that referenced this pull request Dec 22, 2024
@merrymercy
[Misc] Fix metrics, weight update lock, request logging (#2543)
8496701
@merrymercy merrymercy changed the title [Mics] Fix metrics, weight update lock, request logging [Misc] Fix metrics, weight update lock, request logging Dec 22, 2024
chosen-ox pushed a commit to chosen-ox/sglang that referenced this pull request Dec 22, 2024
@merrymercy @chosen-ox
[Misc] Fix metrics, weight update lock, request logging (sgl-project#…
4510c3e 
…2543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

@ByronHsu ByronHsu Awaiting requested review from ByronHsu ByronHsu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@merrymercy