Hypothesis VCF #971
Merged
Hypothesis VCF #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #971 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 41 41
Lines 3841 4276 +435
==========================================
+ Hits 3841 4276 +435
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jeromekelleher
approved these changes
Dec 5, 2022
sgkit/tests/io/vcf/hypothesis_vcf.py
Outdated
| vcf_number: str | ||
|
|
||
| def get_header(self): | ||
| return f'##{self.category}=<ID={self.vcf_key},Type={self.vcf_type},Number={self.vcf_number},Description="{self.category},Type={self.vcf_type},Number={self.vcf_number}">' |
There was a problem hiding this comment.
I'm surprised Black accepts this - any chance we could split it across multiple lines for the console based old fogeys?
There was a problem hiding this comment.
flake8 Line length errors are disabled in this repo (https://github.com/pystatgen/sgkit/blob/main/setup.cfg#L88) and black won't split stings unless you use --preview (psf/black#1331)
There was a problem hiding this comment.
Thanks @benjeffery. So presumably we'll pick that up in a future version of black.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #951
Example of a VCF that this produces:
One notable limitation is that it doesn't generate GT fields. This could be added later.
I've already found (and fixed) one problem with the VCF reader. There are more problems to fix with the writer, which I will address in follow up issues.