-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config with serde & ssh port #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the PR! It certainly makes the code base more idiomatic. I take from the WIP status that you are still working on it. I still left two comments.
Which configuration possibilities do you prefer? |
I'm not sure I understand what you mean exactly. Ideally every option is available as both config file option and cmd line option. But generally I have no strong feelings because I don't rely on the tool anymore. If you think a feature/option is useful and have a good argument in favor of it I'm happy to work on the PR with you and merging it eventually, but I'm not actively working on |
What was the idea of an |
Iirc when
No, not at all, I'm happy someone finds the project useful enough to work on it 😃 |
How should we handle changes in the README? |
At least remove wrong examples, but I'd appreciate it if there was some example config. |
I think it is ready for merging. If you find any shortcomings please let me know. |
Do you wait to merge until the next release to not confuse other people? |
Sorry, I forgot about it a bit, will try to test and merge soon (kinda annoying since it's all manual). |
Don't hurry |
Merged 🎉 do you want me to cut a release? |
It could be a release worth unless there are any changes planned. Btw the |
done |
…-log-level Restore previous log level
The configuration could look like this:
All config options are optional. A check for having a host & user specified, either through cli or config, has to be implemented.
But an alternative could be to allow multiple remotes and picking either the first or one which was specified with a name in the cli (Information for myself: serde-piecewise-default has to be used).
I splitted the host and user into 2 separate entries but I could change that.
The changed command arguments are untested and derived from #13.