Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add start & login fragment for android #26

Merged
merged 25 commits into from
Jan 12, 2024
Merged

feat: add start & login fragment for android #26

merged 25 commits into from
Jan 12, 2024

Conversation

HeewonP825
Copy link
Collaborator

@HeewonP825 HeewonP825 commented Jan 11, 2024 •
edited
Loading

Related Issue

#25

Changes

작업 사항

  • theme, string 세팅
  • navigation 폴더의 nav_graph 파일에 loginFragment, startFragment, PasswordFragment 경로 설정
  • nav_graph에서 action을 사용해서 fragment간 이동 설정
  • fragment_login, fragment_start, fragment_password에서 .xmlui 디자인 완료

To Reviewer

  • 화면은 직접 보셨던 그대로입니다ㅎㅎ

Checklist

  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가
  • PR에 대해 구체적으로 설명이 되어있는가

@HeewonP825
feat: setting android development environment
0c014e8
@HeewonP825
feat: setting navigation graph
4b54621
@HeewonP825
feat: setting ktlint
02d0681
@HeewonP825
feat: setting ktlint
29e93ca
@HeewonP825
feat: setting ktlint
4e59adb
@HeewonP825
chore: test eol at new file
9e0f48b
@HeewonP825
chore: add eol to files
7fb7422
@HeewonP825
chore: add eol to gitignore
a967787
@HeewonP825
chore: add colorList
39d0f4d
@HeewonP825
chore: add font_resource & font_style xml
3f467b7
@HeewonP825
chore: add font style themes
508ce97
@HeewonP825
chore: edit theme colors
b9f3ec0
@HeewonP825
chore: edit font style themes
1a4ef4d
@HeewonP825
feat: add startFragment & edit MainActivity, nav_graph
2fff620
@HeewonP825
feat: add lottieAnimation in Gradle & startFragment
ad835a6
@HeewonP825
feat: edit lottieAnimation size
1b099bc
@HeewonP825
chore: add icons
98c3d59
@HeewonP825
feat: add loginFragment & strings
fa71371
@HeewonP825
feat: add nagivation start to login & loginFragment ui xml
c318d77
@HeewonP825
feat: add String and edit login & loginFragment ui xml
b75be1c
@HeewonP825
feat: add nagivation login to password & PasswordFragment ui xml
791df3f
@HeewonP825
chore: edit letterspacing in themes.xml
5ba4531
@github-actions github-actions bot added android 안드로이드 관련 내용을 다룰 때 사용됩니다 feature 새로운 기능을 만들 때 사용됩니다 labels Jan 11, 2024
@HeewonP825 HeewonP825 marked this pull request as ready for review January 11, 2024 08:47
@HeewonP825 HeewonP825 requested a review from poiu694 as a code owner January 11, 2024 08:47
@HeewonP825 HeewonP825 self-assigned this Jan 11, 2024
poiu694
poiu694 requested changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@poiu694 poiu694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 남겼습니당~

src/mobile/app/src/main/java/com/smilegate/Easel/ui/login/PasswordFragment.kt Outdated
super.onViewCreated(view, savedInstanceState)

}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

eol 부탁드립니다~

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가했습니닿ㅎ

src/mobile/app/src/main/res/drawable/btn_login_fragment_next.xml Outdated
android:shape="rectangle">
<corners android:radius="24dp" />
<solid android:color="@color/Grey_400" />
</shape>
Copy link
Collaborator

@poiu694 poiu694 Jan 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</shape>
</shape>

eol !

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가했어요..ㅎㅎㅎㅎ

src/mobile/app/src/main/res/values/strings.xml
<string name="hello_blank_fragment">Hello blank fragment</string>

<!-- StartFragment -->
<string name="start_fragment_headline">지금 세계에서 무슨 일이 일어\n나고 있는지 알아보세요.</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 부분이랑 아래 부분에서 개행을 강제하는게 나을까요? 뷰포트에 대응이 잘 되는지가 궁금해요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

android:breakStrategy="balanced" 속성을 텍스트뷰에 적용하면 가능하긴한데 그러면 margin값이 무시되는것 같아서 어려울 것 같습니다....ㅠ 일단 개행문자로 하는게 최선일 것 같고 다른 방법이 있나 틈틈히 찾아볼게용

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 :)

@HeewonP825 HeewonP825 requested a review from poiu694 January 12, 2024 01:00
poiu694
poiu694 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@poiu694 poiu694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

죠습니당 🔥🔥

@HeewonP825 HeewonP825 merged commit fe0afb7 into android/dev Jan 12, 2024
1 check passed
@HeewonP825 HeewonP825 deleted the feat/login branch January 12, 2024 01:02
HeewonP825 added a commit that referenced this pull request Jan 22, 2024
@HeewonP825
release: android/dev into main (#93)
e9225cf 
* feat: add start & login fragment for android (#26)

* feat: setting android development environment

* feat: setting navigation graph

* feat: setting ktlint

* feat: setting ktlint

* feat: setting ktlint

* chore: test eol at new file

* chore: add eol to files

* chore: add eol to gitignore

* chore: add colorList

* chore: add font_resource & font_style xml

* chore: add font style themes

* chore: edit theme colors

* chore: edit font style themes

* feat: add startFragment & edit MainActivity, nav_graph

* feat: add lottieAnimation in Gradle & startFragment

* feat: edit lottieAnimation size

* chore: add icons

* feat: add loginFragment & strings

* feat: add nagivation start to login & loginFragment ui xml

* feat: add String and edit login & loginFragment ui xml

* feat: add nagivation login to password  & PasswordFragment ui xml

* chore: edit letterspacing in themes.xml

* chore: review apply

* chore: edit home icon

* feat: add find account Fragment & edit font system in themes (#35)

* chore: add green check icon

* feat: add FindAccountFragment

* feat: edit FindAccountFrangmet for basic setting

* feat: add FindAccountFragment String

* feat: add navigation action in loginFragment & PasswordFragment

* chore: edit font system in themes

* chore: edit textStyle in fragment_password

* feat: add CheckIdFragment

* feat: delete checkidFragment & edit FindAccountFragment btn ui & add underline for passwordFragment string

* feat: edit id name in login/findAccount Fragment

* feat: edit headline weight in fragments

* chore: edit textStyle & delete view in startFragment

* feat: finish login & join View components (#58)

* feat: add createAccountFragment

* feat: add string for createAccountFragment

* feat: edit xml for CreateAccountFragment Ui

* feat: add navigation Action for createAccountFragment

* feat: add action for check icon in CreateAccountFragment

* feat: edit string for CreatAccountFragment

* chore: add icons for password/profile

* feat: edit textcolor for announcement & add toast message

* feat: add SendCodeFragment

* feat: add strings for SendCodeFragment

* feat: add navigation Action for SendCodeFragment

* feat: edit xml & fragment code for SendCodeFragment

* feat: edit string to remove phoneNum & add email/Number Keypad for editText

* feat: add NeedPasswordFragment

* feat: add strings for NeedPasswordFragment

* feat: edit xml & fragment code for NeedPasswordFragment

* feat: add navigation Action for NeedPasswordFragment

* feat: edit directory structure for viewmodel(MVVM) & add JoinViewModel

* feat: add ProfileImageFragment

* feat: add string for ProfileImageFragment

* feat: edit xml & fragment code for ProfileImageFragment

* feat: add navigation Action for ProfileImageFragment

* feat: add Fragment & string for AskNameFragment

* feat: edit xml & fragment code for AskNameFragment

* feat: add navigation Action for AskNameFragment

* feat: remove skip btn in AskNameFragment

* feat: edit JoinViewModel for send livedata fragment to fragment

* feat: edit NeedPasswordFragment to Setting icon action for password inputType On/Off

* feat: edit profileImageFragment to link icon to Gallery

* feat: forbid keybord action(space, enter)

* feat: edit PasswordFragment to Setting icon action for password inputType On/Off

* feat: add viewmodel for login View

* feat: add button activation for all fragments

* feat: change lottie animation

* feat: remove underline in EditText

* feat: add hint animation in join View

* feat: add hint animation in login View

* feat: add validate check for NeedPasswordFragment & add Toast for sendEmail

* feat: add validate check for CreateAccountFragment

* feat: edit ImageView to CardView

* feat: add Image delete btn & logic in ProfileImageFragment

* feat: add keypad dependency in buttons

* feat: edit viewmodel to bundle in login->password logic

* feat: edit FindAccountFragment to remove underline in editText

* feat: remove log

* chore: reflect review

* feat: edit eol

* feat: add toolbar & bottom navigation bar (#71)

* feat: add toolbar & navigation bar basic setting

* feat: change constraintLayout into LinearLayout to pix location & add TimelineFragment

* feat: edit toolbar navigate icon & actions for login/join Views

* feat: setting basic things for timelineFragment

* feat: add toolbar icon in TimelineFragment

* feat: create Fragments for add bottom navigation bar

* feat: edit activity_main.xml for toolbar/navbar/fragmentContainer view problem

* feat: edit margin in loginFragment

* edit bottom_nav

* feat: chained fragmentContainerView in activityMain

* feat: edit toolbar & bottom navigationbar

* feat: delete sucks itemActiceIndicator

* feat: clear doubleClicked icon focus issue

* chore: add eol

* chore: reflect review

* chore: reflect review

* chore: reflect review

* feat: add RecyclerView & TabLayout in TineLine Fragment (#78)

* chore: edit nav_bar visibility for easy dev

* feat: add profile icon for toolbar

* feat: add action for profile icon to navigate ProfileFragment

* feat: add adapter for TimelineFragment & add Tablayout/ViewPager

* feat: add ForToyFragment/TimeLineFragment & edit toolbar bg/indicator color

* feat: add item_timeline for timeline RecyclerView

* feat: edit item_timeline for timeline RecyclerView

* feat: edit TimeLineItem dataclass for nullable components

* feat: add recyclerView in FollowingFragment

* feat: edit profileImg to nullable & remove touch animation in bottombar

* feat: add scroll action save logic in RV

* feat: add json file & edit icon size

* chore: add icons for post menu

* feat: edit TimelineRVAdapter
This was referenced Feb 21, 2024
Closed
Merged
HeewonP825 added a commit that referenced this pull request Feb 22, 2024
@HeewonP825
release: android/release into main (#293)
17ebc0a 
* feat: add start & login fragment for android (#26)

* feat: setting android development environment

* feat: setting navigation graph

* feat: setting ktlint

* feat: setting ktlint

* feat: setting ktlint

* chore: test eol at new file

* chore: add eol to files

* chore: add eol to gitignore

* chore: add colorList

* chore: add font_resource & font_style xml

* chore: add font style themes

* chore: edit theme colors

* chore: edit font style themes

* feat: add startFragment & edit MainActivity, nav_graph

* feat: add lottieAnimation in Gradle & startFragment

* feat: edit lottieAnimation size

* chore: add icons

* feat: add loginFragment & strings

* feat: add nagivation start to login & loginFragment ui xml

* feat: add String and edit login & loginFragment ui xml

* feat: add nagivation login to password  & PasswordFragment ui xml

* chore: edit letterspacing in themes.xml

* chore: review apply

* chore: edit home icon

* feat: add find account Fragment & edit font system in themes (#35)

* chore: add green check icon

* feat: add FindAccountFragment

* feat: edit FindAccountFrangmet for basic setting

* feat: add FindAccountFragment String

* feat: add navigation action in loginFragment & PasswordFragment

* chore: edit font system in themes

* chore: edit textStyle in fragment_password

* feat: add CheckIdFragment

* feat: delete checkidFragment & edit FindAccountFragment btn ui & add underline for passwordFragment string

* feat: edit id name in login/findAccount Fragment

* feat: edit headline weight in fragments

* chore: edit textStyle & delete view in startFragment

* feat: finish login & join View components (#58)

* feat: add createAccountFragment

* feat: add string for createAccountFragment

* feat: edit xml for CreateAccountFragment Ui

* feat: add navigation Action for createAccountFragment

* feat: add action for check icon in CreateAccountFragment

* feat: edit string for CreatAccountFragment

* chore: add icons for password/profile

* feat: edit textcolor for announcement & add toast message

* feat: add SendCodeFragment

* feat: add strings for SendCodeFragment

* feat: add navigation Action for SendCodeFragment

* feat: edit xml & fragment code for SendCodeFragment

* feat: edit string to remove phoneNum & add email/Number Keypad for editText

* feat: add NeedPasswordFragment

* feat: add strings for NeedPasswordFragment

* feat: edit xml & fragment code for NeedPasswordFragment

* feat: add navigation Action for NeedPasswordFragment

* feat: edit directory structure for viewmodel(MVVM) & add JoinViewModel

* feat: add ProfileImageFragment

* feat: add string for ProfileImageFragment

* feat: edit xml & fragment code for ProfileImageFragment

* feat: add navigation Action for ProfileImageFragment

* feat: add Fragment & string for AskNameFragment

* feat: edit xml & fragment code for AskNameFragment

* feat: add navigation Action for AskNameFragment

* feat: remove skip btn in AskNameFragment

* feat: edit JoinViewModel for send livedata fragment to fragment

* feat: edit NeedPasswordFragment to Setting icon action for password inputType On/Off

* feat: edit profileImageFragment to link icon to Gallery

* feat: forbid keybord action(space, enter)

* feat: edit PasswordFragment to Setting icon action for password inputType On/Off

* feat: add viewmodel for login View

* feat: add button activation for all fragments

* feat: change lottie animation

* feat: remove underline in EditText

* feat: add hint animation in join View

* feat: add hint animation in login View

* feat: add validate check for NeedPasswordFragment & add Toast for sendEmail

* feat: add validate check for CreateAccountFragment

* feat: edit ImageView to CardView

* feat: add Image delete btn & logic in ProfileImageFragment

* feat: add keypad dependency in buttons

* feat: edit viewmodel to bundle in login->password logic

* feat: edit FindAccountFragment to remove underline in editText

* feat: remove log

* chore: reflect review

* feat: edit eol

* feat: add toolbar & bottom navigation bar (#71)

* feat: add toolbar & navigation bar basic setting

* feat: change constraintLayout into LinearLayout to pix location & add TimelineFragment

* feat: edit toolbar navigate icon & actions for login/join Views

* feat: setting basic things for timelineFragment

* feat: add toolbar icon in TimelineFragment

* feat: create Fragments for add bottom navigation bar

* feat: edit activity_main.xml for toolbar/navbar/fragmentContainer view problem

* feat: edit margin in loginFragment

* edit bottom_nav

* feat: chained fragmentContainerView in activityMain

* feat: edit toolbar & bottom navigationbar

* feat: delete sucks itemActiceIndicator

* feat: clear doubleClicked icon focus issue

* chore: add eol

* chore: reflect review

* chore: reflect review

* chore: reflect review

* feat: add RecyclerView & TabLayout in TineLine Fragment (#78)

* chore: edit nav_bar visibility for easy dev

* feat: add profile icon for toolbar

* feat: add action for profile icon to navigate ProfileFragment

* feat: add adapter for TimelineFragment & add Tablayout/ViewPager

* feat: add ForToyFragment/TimeLineFragment & edit toolbar bg/indicator color

* feat: add item_timeline for timeline RecyclerView

* feat: edit item_timeline for timeline RecyclerView

* feat: edit TimeLineItem dataclass for nullable components

* feat: add recyclerView in FollowingFragment

* feat: edit profileImg to nullable & remove touch animation in bottombar

* feat: add scroll action save logic in RV

* feat: add json file & edit icon size

* chore: add icons for post menu

* feat: edit TimelineRVAdapter

* feat: add bottomSheetDialog & Menu & FAB (#114)

* feat:add bottomSheetDialog for Timeline

* feat:add bottomSheetDialog xml for Timeline

* feat: add behavior navigationBar & edit bottomsheet

* feat: add fab btn & animation in timeline Fragment

* feat: add fab btn & animation in timeline Fragment

* fix: edit Viewpager overFlow

* fix:remove bottomSheetDialog

* feat: edit fab margin in constraintlayout

* feat: add dummy data for Timeline

* feat: add fab in navigation Fragment

* feat: edit fab in messageFragment

* feat: add vibrate for longClick

* feat: add icons for popupmenu & add basic popupMenu

* feat: add custom popup menu xml

* feat: add custom popup into TimeLineRVAdapter

* feat: edit custom popup tv

* feat: add bottomSheetDialog

* chore: rename Timeline package to timeline

* feat: add post Fragment

* feat: add navigation actions to post Fragment

* feat: add actions for fab to PostFragment

* fix: fix navigation actions to post Fragment

* feat: add xml for ProfileFragment

* feat: add action in MypageFragment(before ProfileFragment)

* feat: add toggle action in MypageFragment

* feat: add lightMode icon & Toast

* feat: try to add animation in MyPageFragment

* feat: add overlay view in TimelineFragment

* feat:divide bottomSheetDialog into Rt & share

* feat: add Toast into MyPageFragment

* feat: add ViewBottomSheetDialog

* feat: edit button to android.widget.button

* chore: add eol

* chore: reflect review

* chore:reflect review

* feat: add ic_up_arrow

* chore:reflect review

* feat: fix FAB animation bug

* chore:reflect review

* feat: remove elevation in bottomSheet btn

* feat: add ProfileFragment & BookMarkFragment (#121)

* feat: add profileFragment.xml before tablayout

* feat: add viewPager & TabLayout in ProfileFragment

* feat: add RV in MyPostFragment & edit doublePressed Logic in ForYou/Following Fragment

* feat: add RV in ReplyFragment

* feat: add RV in LikedFragment

* feat: add RV in MediaFragment

* feat: add RV in HighlightFragment

* feat: change scrollview into NestedScrollView

* feat: try to change statusBar Transperent

* feat: add naviation for ProfileFragment & ViewPager

* feat: Edit HighlighFragment to subscribe xml

* feat: add FAB in ProfileFragment

* feat: edit toobal & navBar visibility

* feat: add BookMarkFragment & nav Actions

* feat: add RV & toolbar Visibility for BookMarkFragment

* feat: add layout for when bookMark is empty

* feat: edit navigation in MyPageFragment

* chore: add icon

* chore: add eol

* feat: add scroll action in ProfileFragment (#158)

* chore: remove unused behavior.kt

* feat: add SwipeRefresh in Timeline

* feat: try to forbid basicBackbtn in ProfileFragment

* feat: add nestedScrollableHost/icon  & edit color theme name

* chore: add Timber in Dependency & MainActivity

* feat: remove scrollView in RV

* feat: remove scrollView in RV

* feat: remove scrollView in RV

* feat: divide ConstraintLayout into 2

* feat: edit xml for scrollView

* feat: add action in backbtn for ProfileFragment

* feat: add SwipeRefresh in xml

* feat: add swipe action in Tablayout

* extract Method for RV in ProfileFragment

* feat: try to add Highlight RV for ProfileFragment Tablayout

* feat: make FAB cannot scroll

* chore:add eol

* feat: edit popupMenu constraintLayout

* chore: add eol

* chore: reflect review

* chore: reflect review

* chore: reflect review

* chore: reflect review

* chore: reflect review

* chore: add eol

* chore: add eol

* feat: add PostFragment (#234)

* feat: remove toolbar&navigation in PostFragment

* feat: edit fragment_post.xml

* feat: edit post_fragment.xml

* feat: add textWatcher action & photo plus btn in PostFragment

* feat: add CircularProgressBar

* feat: add CircularProgressBar

* fix: edit constraintLayout for editText space

* fix: add img RV in PostFragment

* fix: add horizontalScrollView

* feat: link Gallery to PostFragment RV with Glide

* feat: add border & cardView in Item_post_img

* feat: add action for backbtn in PostFragment

* chore:edit opacity for popup menu

* feat: load Img from gallery to PostFragment

* feat: change view's ConstraintLayout in PostFragment

* feat: change enable btn in postFragment

* feat: change deleteBtn translationZ

* fix: fix upload sequence error

* feat: add setOnClickListener in Horizontal RV

* feat: change enable btn in postFragment

* feat: change enable btn when add img in postFragment

* chore:reflect review

* chore:reflect review

* chore:reflect review

* chore:reflect review

* feat: add quote & detail fragment (#279)

* feat: add quote text & image ver

* feat: add MultiView(quote text & image) in RV

* feat: edit MultiView(quote text & image) margin & border in RV

* feat: set Visibility for MultiView(quote text & image) in RV

* feat: add margin for MultiView(quote text & image) in RV

* feat: add postDetailFragment

* feat: add item_post_detail.xml

* feat: edit item_post_detail.xml

* feat: add api for login&join (#292)

* feat:add api(users/verify-email, users/temporary-join)

* feat:add api(auth)

* feat:add api(user/join) except profileImg

* feat:add api(auth/mobile) & tokenManager

* feat:add api(users/me)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poiu694 poiu694 poiu694 approved these changes

Assignees

@HeewonP825 HeewonP825

Labels
android 안드로이드 관련 내용을 다룰 때 사용됩니다 feature 새로운 기능을 만들 때 사용됩니다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeewonP825 @poiu694