Enable the use of system-wide proxys #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the use of system-wide proxy
sfudeus
reviewed
Mar 24, 2024
| def __init__(self): | ||
| proxy_http = os.environ.get('http_proxy') | ||
| proxy_https = os.environ.get('https_proxy') | ||
| proxy = proxy_https if proxy_https else proxy_http |
There was a problem hiding this comment.
The fallback is mostly intended, but not helpful when only one scheme needs a proxy and the other doesn't. And the main decision should be taken on the originally requested scheme.
sfudeus
reviewed
Mar 24, 2024
| super().__init__(self) | ||
|
|
||
| def make_connection(self, host): | ||
| if not self.proxy or host.startswith('https'): |
There was a problem hiding this comment.
even https could be proxied (through the https_proxy)
|
Good suggestion, though it is a pity that the xmlrpc lient and transport don't support this out of the box. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow homematic_exporter to use the system-wide configured http(s) proxy