Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cross compile with target i686-linux-android #626

Closed
wants to merge 2 commits into from
Closed

fix cross compile with target i686-linux-android #626

wants to merge 2 commits into from

Conversation

hlzhang
Copy link

@hlzhang hlzhang commented May 3, 2017

fix #625

@sfackler
Copy link
Owner

sfackler commented May 3, 2017

I believe this is due to a fix in libc's definition of c_char on Android. Does the build work on using nightly Rust?

@hlzhang
Copy link
Author

hlzhang commented May 9, 2017

I didn't try nightly Rust.

@sfackler
Copy link
Owner

sfackler commented May 9, 2017

Everything should work fine as is if you use a rustc that includes rust-lang/rust#40317.

@hlzhang
Copy link
Author

hlzhang commented May 24, 2017

@sfackler Thanks. You are right, it works!

@hlzhang hlzhang closed this May 24, 2017
@clehner clehner mentioned this pull request Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't compile with target i686-linux-android
2 participants
@hlzhang @sfackler