Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building with latest BoringSSL #2121

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Conversation

alex
Copy link
Collaborator

@alex alex commented Dec 7, 2023

No description provided.

@alex
Copy link
Collaborator Author

alex commented Dec 7, 2023

@sfackler I think we need a from_ptr that works with *const ptrs. I guess there's a challenge here because we're not on the latest foreign-types.

@sfackler
Copy link
Owner

sfackler commented Dec 7, 2023

We have an extension trait you can add it to: https://github.com/sfackler/rust-openssl/blob/master/openssl/src/util.rs#L69

Keep in mind that *const vs *mut is purely advisory in Rust - unlike with references, there are no safety implications in casting a const pointer to a mut one.

@alex
Copy link
Collaborator Author

alex commented Dec 7, 2023

Huh. What do you know. Updated to use that and two other places we should have used it recently.

@alex alex requested a review from sfackler December 8, 2023 02:23
@sfackler sfackler merged commit e053a9c into sfackler:master Dec 9, 2023
53 checks passed
@alex alex deleted the boringssl-build branch December 9, 2023 01:40
bob-beck pushed a commit to openbsd/ports that referenced this pull request Dec 12, 2023
X509V3_EXT_add_alias() will go away and X509_PURPOSE_get0() will return
a const pointer. This breaks the build of the vendored rust-openssl crate.
Fix this by pulling in (parts of) the following upstream PRs:

sfackler/rust-openssl#2121
sfackler/rust-openssl#2124

ok semarie (maintainer)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants