Added support for building boringssl with bindgen #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
boring-bindgen
branch
5 times, most recently
from
4ab456e to
da286ca
Compare
alex
force-pushed
the
boring-bindgen
branch
2 times, most recently
from
f4bbba8 to
8f28aa9
Compare
This allows building it without the bssl-sys crate. This is an alternative approach to fixing sfackler#1768 (in contrast to sfackler#1806). This maintains support for using the bssl-sys crate.
sfackler
reviewed
Mar 15, 2023
| } | ||
|
|
||
| #[cfg(not(feature = "bindgen"))] | ||
| pub fn run_boringssl(include_dirs: &[PathBuf]) { |
There was a problem hiding this comment.
It seems a bit unfortunate to be duplicating all of the bindgen flags here and above. If we end up having to tweak them in the future we should probably refactor.
There was a problem hiding this comment.
Agreed, and yes, makes sense.
davidben
reviewed
Mar 15, 2023
| .arg("--rustified-enum=point_conversion_form_t") | ||
| .arg("--allowlist-file=.*/openssl/[^/]+\\.h") | ||
| .arg("--experimental") | ||
| .arg("--wrap-static-fns") |
There was a problem hiding this comment.
Based on, it doesn't look like this flag works correctly in bindgen yet, so from BoringSSL's perspective, this bindings strategy is unsupported. I'd love to see a version of it that works, but bindgen isn't there yet.
https://boringssl-review.googlesource.com/c/boringssl/+/56505/8/rust/CMakeLists.txt#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows building it without the bssl-sys crate. This is an alternative approach to fixing #1768 (in contrast to #1806).
This maintains support for using the bssl-sys crate.