Add NID constants for Brainpool curves #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
force-pushed
the
add-brainpool
branch
from
123f9d6
to
35ae34b
Compare
|
It looks like they're not present in 1.0.1. LGTM otherwise! |
wiktor-k
force-pushed
the
add-brainpool
branch
from
35ae34b
to
f4520e9
Compare
|
Thanks for the hint the error messages can be a little bit confusing at first... Is there a way to check which version of OpenSSL introduced which curves? I've tried to get the |
Brainpool curves are used by European government organizations that are suspicious of the NIST curves. Brainpool curves are very similar to NIST curves with one critical difference: the parameters to Brainpool are nothing-up-my-sleeve numbers [0]. The actual values of the NID constants have been taken from the OpenSSL source code [1]. [0]: https://github.com/veorq/numsgen#seeds [1]: https://github.com/openssl/openssl/blob/4e6647506331fc3b3ef5b23e5dbe188279ddd575/include/openssl/obj_mac.h#L4759
wiktor-k
force-pushed
the
add-brainpool
branch
from
f4520e9
to
b82aae3
Compare
|
I usually just look through the releases manually to see when they ended up in the headers the first time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brainpool curves are used by European government organizations that are suspicious of the NIST curves. Brainpool curves are very similar to NIST curves with one critical difference: the parameters to Brainpool are nothing-up-my-sleeve numbers.
The actual values of the NID constants have been taken from the OpenSSL source code.