Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy old codes that support Rust version below min-version #1963

Closed
faptc opened this issue Jun 15, 2023 · 2 comments · Fixed by #1966
Closed

Tidy old codes that support Rust version below min-version #1963

faptc opened this issue Jun 15, 2023 · 2 comments · Fixed by #1966

Comments

@faptc
Copy link

faptc commented Jun 15, 2023

As far as I could tell, the min-version in ci.yml was bumped to 1.56 last year.

Should we try to clean up old codes like this one:

#[allow(clippy::manual_strip)] // we need to support pre-1.45.0

@alex
Copy link
Collaborator

alex commented Jun 15, 2023 via email

@sfackler
Copy link
Owner

Yeah, we should definitely clean up stuff to support pre-1.56 releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants