Move hir place #19
Move hir place #19
Conversation
arora-aman
requested review from
Azhng,
ChrisPardy,
jenniferwills,
logmosier,
null-sleep and
roxelo
|
This will let Logan/ Archer/ whoever has some time to work on rust-lang/project-rfc-2229#7 PR that Chris, Dhruv and I are working on will have some impact, nothing too bad. Hopefully Archer's PR gets merged soon and I will remove the commit from this branch then. This builds and that should mostly be it, clippy tests passed. Complete test suite running here: http://csclub.uwaterloo.ca/~a52arora/rust-builds/log_commit_861cfd2d0614d8bfeff70c30131a3cacb996c9e1_918a4302-c93d-4474-8291-c3f48d787aae |
|
Discussion relating to move the HIR Place to middle/hir: https://rust-lang.zulipchat.com/#narrow/stream/189812-t-compiler.2Fwg-rfc-2229/topic/Typecheck.20tables.20using.20Places/near/201773438 |
arora-aman
force-pushed
the
move_hir_place
branch
from
861cfd2 to
bd5e63c
Compare
arora-aman
force-pushed
the
move_hir_place
branch
2 times, most recently
from
7efc783 to
c1e4eaa
Compare
Needed to support rust-lang/project-rfc-2229#7 Currently rustc_typeck depends on rustc_middle for definition TypeckTables, etc. For supporting project-rfc-2229#7, rustc_middle would've to depend on rustc_typeck for Place -- introducing a circular dependcy. This resembles the MIR equivalent of `Place` located in `lbrustc_middle/mir`. Co-authored-by: Aman Arora <me@aman-arora.com> Co-authored-by: Jennifer Wills <wills.jenniferg@gmail.com> Co-authored-by: Logan Mosier <logmosier@gmail.com>
arora-aman
force-pushed
the
move_hir_place
branch
from
c1e4eaa to
50f3dbd
Compare
|
Rebased and tests passed: http://csclub.uwaterloo.ca/~a52arora/rust-builds/log_06bef156-2ef2-4836-bb78-b06b0d17dde7 |
|
rust-lang PR: rust-lang#74424 |
Needed to support rust-lang/project-rfc-2229#7
This resembles the MIR equivalent located in
lbrustc_middle/mir.This change is