Fix nginx config task work with roles #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix a typo in puma_nginx role assignment; * move role assignment to nginx.cap; * show error message when puma_nginx role not set; * add few lines about the role in README.
| namespace :puma do | ||
| desc "Setup nginx configuration" | ||
| task :nginx_config do | ||
| fail ":puma_nginx role not set!" if roles(:puma_nginx).empty? |
There was a problem hiding this comment.
Do we really need that ?
.empty? is defined in activesupport unless it an array.
There was a problem hiding this comment.
But roles returns an Array, isn't it? ActiveSupport not involved.
There was a problem hiding this comment.
Right. But i think it better if we don't raise a error.
There was a problem hiding this comment.
With no :web or :puma_nginx roles defined, the user won't know why the config wasn't uploaded. The task will be executed like it's okay. But if you insist, I'll remove this line.
seuros
added a commit
that referenced
this pull request
Oct 5, 2014
Fix nginx config task work with roles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71