Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thanks for the gem, great work!
When trying to integrate with upstart, I think it would be better if the daemonize option were not hardcoded into the
puma.rb
file. Otherwise, upstart is completely lost and thinks the daemon hasn't started. FYI I also tried using the upstart stanzasexpect daemon
andexpect fork
but without success (and it's not recommended anyway).More generally, I think it makes sense to explicitly daemonize on the command line, instead of forcing it for all peripheral services that may want to reuse the
puma.rb
config file.For reference, here is my example upstart config file:
These small changes would allow upstart and capistrano to cohabit peacefully. Let me know what you think.